summaryrefslogtreecommitdiffstats
path: root/docs/virtio-balloon-stats.txt
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2016-02-17 23:48:16 -0700
committerTimothy Pearson <tpearson@raptorengineering.com>2019-11-29 19:45:30 -0600
commit6c5dc2fd9a9065a7e5738a5b06e9ce1f51b0ef55 (patch)
treef0d00585678e3e301126aae0f1aee9936067c540 /docs/virtio-balloon-stats.txt
parentf5c39f9c4210f444621965df2fb1304a39cadf77 (diff)
downloadhqemu-6c5dc2fd9a9065a7e5738a5b06e9ce1f51b0ef55.zip
hqemu-6c5dc2fd9a9065a7e5738a5b06e9ce1f51b0ef55.tar.gz
qapi: Forbid empty unions and useless alternates
Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We happen to inject a dummy 'void *data' member into the C unions that represent QAPI unions and alternates, but we want to get rid of that member (it pollutes the namespace for no good reason), which would leave us with an empty union if the user didn't provide any branches. While empty structs make sense in QAPI, empty unions don't add any expressiveness to the QMP language. So prohibit them at parse time. Update the documentation and testsuite to match. Note that the documentation already mentioned that alternates should have "two or more JSON data types"; so this also fixes the code to enforce that. However, we have existing uses of a union type with only one branch, so the 2-or-more strictness is intentionally limited to alternates. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1455778109-6278-3-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'docs/virtio-balloon-stats.txt')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud