summaryrefslogtreecommitdiffstats
path: root/block
diff options
context:
space:
mode:
authorDr. David Alan Gilbert <dgilbert@redhat.com>2015-05-19 12:29:52 +0100
committerJuan Quintela <quintela@redhat.com>2015-06-12 06:54:01 +0200
commitf68945d42bab700d95b87f62e0898606ce2421ed (patch)
tree0d913299a9277113965dba147220975e484c02c8 /block
parent37fb569c0198cba58e3e1bdf6b9702c8248b89dd (diff)
downloadhqemu-f68945d42bab700d95b87f62e0898606ce2421ed.zip
hqemu-f68945d42bab700d95b87f62e0898606ce2421ed.tar.gz
Add a protective section footer
Badly formatted migration streams can go undetected or produce misleading errors due to a lock of checking at the end of sections. In particular a section that adds an extra 0x00 at the end causes what looks like a normal end of stream and thus doesn't produce any errors, and something that ends in a 0x01..0x04 kind of look like real section headers and then fail when the section parser tries to figure out which section they are. This is made worse by the choice of 0x00..0x04 being small numbers that are particularly common in normal section data. This patch adds a section footer consisting of a marker (0x7e - ~) followed by the section-id that was also sent in the header. If they mismatch then it throws an error explaining which section was being loaded. Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Juan Quintela <quintela@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud