summaryrefslogtreecommitdiffstats
path: root/block/mirror.c
diff options
context:
space:
mode:
authorJeff Cody <jcody@redhat.com>2015-01-22 08:03:29 -0500
committerKevin Wolf <kwolf@redhat.com>2015-01-23 18:17:06 +0100
commit1d33936ea847693a6d69f9049691a0341d6e0b9f (patch)
tree1aa5c98c41e249c39d3aa3d4c08df4b2f975efe1 /block/mirror.c
parenta1a11d10abfff6638479b7510ee1df4f737d89d6 (diff)
downloadhqemu-1d33936ea847693a6d69f9049691a0341d6e0b9f.zip
hqemu-1d33936ea847693a6d69f9049691a0341d6e0b9f.tar.gz
block: mirror - change string allocation to 2-bytes
The backing_filename string in mirror_run() is only used to check for a NULL string, so we don't need to allocate 1024 bytes (or, later, PATH_MAX bytes), when we only need to copy the first 2 characters. We technically only need 1 byte, as we are just checking for NULL, but since backing_filename[] is populated by bdrv_get_backing_filename(), a string size of 1 will always only return '\0'; Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> Signed-off-by: Jeff Cody <jcody@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block/mirror.c')
-rw-r--r--block/mirror.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/block/mirror.c b/block/mirror.c
index 9019d1b..4056164 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -378,7 +378,8 @@ static void coroutine_fn mirror_run(void *opaque)
int64_t sector_num, end, sectors_per_chunk, length;
uint64_t last_pause_ns;
BlockDriverInfo bdi;
- char backing_filename[1024];
+ char backing_filename[2]; /* we only need 2 characters because we are only
+ checking for a NULL string */
int ret = 0;
int n;
OpenPOWER on IntegriCloud