diff options
author | Kevin Wolf <kwolf@redhat.com> | 2015-05-08 15:14:15 +0200 |
---|---|---|
committer | Timothy Pearson <tpearson@raptorengineering.com> | 2019-11-29 19:28:20 -0600 |
commit | cdd488101e8cb522a14112fdbd1e7317e846cc64 (patch) | |
tree | 1e638fff6924b2e62becf9a07d743215122f6bbd /block.c | |
parent | f76d1d7062dc3bca8ab5cc74b30fd2468d4724ba (diff) | |
download | hqemu-cdd488101e8cb522a14112fdbd1e7317e846cc64.zip hqemu-cdd488101e8cb522a14112fdbd1e7317e846cc64.tar.gz |
block: Allow specifying child options in reopen
If the child was defined in the same context (-drive argument or
blockdev-add QMP command) as its parent, a reopen of the parent should
work the same and allow changing options of the child.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Diffstat (limited to 'block.c')
-rw-r--r-- | block.c | 12 |
1 files changed, 10 insertions, 2 deletions
@@ -1720,15 +1720,23 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue *bs_queue, flags &= ~BDRV_O_PROTOCOL; QLIST_FOREACH(child, &bs->children, next) { + QDict *new_child_options; + char *child_key_dot; int child_flags; + /* reopen can only change the options of block devices that were + * implicitly created and inherited options. For other (referenced) + * block devices, a syntax like "backing.foo" results in an error. */ if (child->bs->inherits_from != bs) { continue; } + child_key_dot = g_strdup_printf("%s.", child->name); + qdict_extract_subqdict(options, &new_child_options, child_key_dot); + g_free(child_key_dot); + child_flags = child->role->inherit_flags(flags); - /* TODO Pass down child flags (backing.*, extents.*, ...) */ - bdrv_reopen_queue(bs_queue, child->bs, NULL, child_flags); + bdrv_reopen_queue(bs_queue, child->bs, new_child_options, child_flags); } bs_entry = g_new0(BlockReopenQueueEntry, 1); |