summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2016-03-08 15:27:30 +0000
committerTimothy Pearson <tpearson@raptorengineering.com>2019-11-29 19:49:36 -0600
commitaa42abca06abdb039b24ec909680b720f4c4aca7 (patch)
treedca8317323e011ccde110aea96b1dba5a8c76e2b
parent23e156e6eb996888c3f16f6139bd47fe78f746f1 (diff)
downloadhqemu-aa42abca06abdb039b24ec909680b720f4c4aca7.zip
hqemu-aa42abca06abdb039b24ec909680b720f4c4aca7.tar.gz
io: bind to socket before creating QIOChannelSocket
In the QIOChannelSocket test we create a socket file descriptor and then try to create a QIOChannelSocket. This works on Linux, but fails on Win32 because it is not valid to call getsockname() on an unbound socket. Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
-rw-r--r--tests/test-io-channel-socket.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/tests/test-io-channel-socket.c b/tests/test-io-channel-socket.c
index f226e47..4c16da1 100644
--- a/tests/test-io-channel-socket.c
+++ b/tests/test-io-channel-socket.c
@@ -470,10 +470,20 @@ static void test_io_channel_ipv4_fd(void)
{
QIOChannel *ioc;
int fd = -1;
+ struct sockaddr_in sa = {
+ .sin_family = AF_INET,
+ .sin_addr = {
+ .s_addr = htonl(INADDR_LOOPBACK),
+ }
+ /* Leave port unset for auto-assign */
+ };
+ socklen_t salen = sizeof(sa);
fd = socket(AF_INET, SOCK_STREAM, 0);
g_assert_cmpint(fd, >, -1);
+ g_assert_cmpint(bind(fd, (struct sockaddr *)&sa, salen), ==, 0);
+
ioc = qio_channel_new_fd(fd, &error_abort);
g_assert_cmpstr(object_get_typename(OBJECT(ioc)),
OpenPOWER on IntegriCloud