diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2015-06-17 10:36:54 +0200 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2015-06-19 12:27:14 +0200 |
commit | e4a511f8cc6f4a46d409fb5c9f72c38ba45f8d83 (patch) | |
tree | 0d3a18cf62f3079370d7c412b378aef00fdece8c | |
parent | 965eb2fcdfe919ecced6c34803535ad32dc1249c (diff) | |
download | hqemu-e4a511f8cc6f4a46d409fb5c9f72c38ba45f8d83.zip hqemu-e4a511f8cc6f4a46d409fb5c9f72c38ba45f8d83.tar.gz |
exec: clamp accesses against the MemoryRegionSection
Because the clamping was done against the MemoryRegion,
address_space_rw was effectively broken if a write spanned
multiple sections that are not linear in underlying memory
(with the memory not being under an IOMMU).
This is visible with the MIPS rc4030 IOMMU, which is implemented
as a series of alias memory regions that point to the actual RAM.
Tested-by: Hervé Poussineau <hpoussin@reactos.org>
Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r-- | exec.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -353,7 +353,7 @@ address_space_translate_internal(AddressSpaceDispatch *d, hwaddr addr, hwaddr *x mr = section->mr; if (memory_region_is_ram(mr)) { - diff = int128_sub(mr->size, int128_make64(addr)); + diff = int128_sub(section->size, int128_make64(addr)); *plen = int128_get64(int128_min(diff, int128_make64(*plen))); } return section; |