summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Weil <sw@weilnetz.de>2015-03-11 22:08:56 +0100
committerStefan Weil <sw@weilnetz.de>2015-11-30 06:47:02 +0100
commit857a0e387a6c91b5ea012aafae04c95eba314306 (patch)
tree8bd0ab49c50c5579b69c68fc0921582fabeda887
parent714487515dbe0c65d5904251e796cd3a5b3579fb (diff)
downloadhqemu-857a0e387a6c91b5ea012aafae04c95eba314306.zip
hqemu-857a0e387a6c91b5ea012aafae04c95eba314306.tar.gz
trace/simple: Fix warning and wrong trace file name for MinGW
On Windows, getpid() always returns an int value, but pid_t (which is expected by the format string) is either a 32 bit or a 64 bit value. Without a type cast (or a modified format string), the compiler prints a warning when building for 64 bit Windows and the resulting trace_file_name will include a wrong pid: trace/simple.c:332:9: warning: format ‘%lld’ expects argument of type ‘long long int’, but argument 2 has type ‘int’ [-Wformat=] Signed-off-by: Stefan Weil <sw@weilnetz.de>
-rw-r--r--trace/simple.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/trace/simple.c b/trace/simple.c
index 11ad030..56a624c 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -329,7 +329,8 @@ bool st_set_trace_file(const char *file)
g_free(trace_file_name);
if (!file) {
- trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, getpid());
+ /* Type cast needed for Windows where getpid() returns an int. */
+ trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, (pid_t)getpid());
} else {
trace_file_name = g_strdup_printf("%s", file);
}
OpenPOWER on IntegriCloud