summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKevin Wolf <mail@kevin-wolf.de>2009-05-23 11:21:33 +0200
committerAnthony Liguori <aliguori@us.ibm.com>2009-05-27 09:45:06 -0500
commitcab3c825371b73fa71ada4dfa8d64ca99bc08638 (patch)
treedb7c1310d67597b70cadc2667aa93d695f29e0f3
parent8cf07dcbe7691dbe4f47563058659dba6ef66b05 (diff)
downloadhqemu-cab3c825371b73fa71ada4dfa8d64ca99bc08638.zip
hqemu-cab3c825371b73fa71ada4dfa8d64ca99bc08638.tar.gz
e1000: Ignore reset command
When a reset is requested, the current e1000 emulation never clears the reset bit which may cause a driver to hang. This patch masks the reset bit out when setting the control registert, so the reset is immediately completed. Signed-off-by: Kevin Wolf <mail@kevin-wolf.de> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-rw-r--r--hw/e1000.c11
1 files changed, 9 insertions, 2 deletions
diff --git a/hw/e1000.c b/hw/e1000.c
index c5eb546..2665792 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -190,6 +190,13 @@ rxbufsize(uint32_t v)
}
static void
+set_ctrl(E1000State *s, int index, uint32_t val)
+{
+ /* RST is self clearing */
+ s->mac_reg[CTRL] = val & ~E1000_CTRL_RST;
+}
+
+static void
set_rx_control(E1000State *s, int index, uint32_t val)
{
s->mac_reg[RCTL] = val;
@@ -783,12 +790,12 @@ enum { NREADOPS = ARRAY_SIZE(macreg_readops) };
static void (*macreg_writeops[])(E1000State *, int, uint32_t) = {
putreg(PBA), putreg(EERD), putreg(SWSM), putreg(WUFC),
putreg(TDBAL), putreg(TDBAH), putreg(TXDCTL), putreg(RDBAH),
- putreg(RDBAL), putreg(LEDCTL), putreg(CTRL), putreg(VET),
+ putreg(RDBAL), putreg(LEDCTL), putreg(VET),
[TDLEN] = set_dlen, [RDLEN] = set_dlen, [TCTL] = set_tctl,
[TDT] = set_tctl, [MDIC] = set_mdic, [ICS] = set_ics,
[TDH] = set_16bit, [RDH] = set_16bit, [RDT] = set_rdt,
[IMC] = set_imc, [IMS] = set_ims, [ICR] = set_icr,
- [EECD] = set_eecd, [RCTL] = set_rx_control,
+ [EECD] = set_eecd, [RCTL] = set_rx_control, [CTRL] = set_ctrl,
[RA ... RA+31] = &mac_writereg,
[MTA ... MTA+127] = &mac_writereg,
[VFTA ... VFTA+127] = &mac_writereg,
OpenPOWER on IntegriCloud