diff options
author | Kevin Wolf <kwolf@redhat.com> | 2009-11-18 12:15:10 +0100 |
---|---|---|
committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-12-03 15:26:00 -0600 |
commit | 6769da29c7a3caa9de4020db87f495de692cf8e2 (patch) | |
tree | e7284851ee1ecb1c86c6078aca5abf3c8c2864f2 | |
parent | 7078dead94a24bc4e5819e4a6448bd5738a2d088 (diff) | |
download | hqemu-6769da29c7a3caa9de4020db87f495de692cf8e2.zip hqemu-6769da29c7a3caa9de4020db87f495de692cf8e2.tar.gz |
posix-aio-compat: Fix error check
Checking for nbytes < 0 is pointless as long as it's a size_t. If we want to
use negative numbers for error codes, we should use signed types.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-rw-r--r-- | posix-aio-compat.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/posix-aio-compat.c b/posix-aio-compat.c index ac247e1..dc14f53 100644 --- a/posix-aio-compat.c +++ b/posix-aio-compat.c @@ -117,7 +117,7 @@ static void thread_create(pthread_t *thread, pthread_attr_t *attr, if (ret) die2(ret, "pthread_create"); } -static size_t handle_aiocb_ioctl(struct qemu_paiocb *aiocb) +static ssize_t handle_aiocb_ioctl(struct qemu_paiocb *aiocb) { int ret; @@ -136,7 +136,7 @@ static size_t handle_aiocb_ioctl(struct qemu_paiocb *aiocb) return aiocb->aio_nbytes; } -static size_t handle_aiocb_flush(struct qemu_paiocb *aiocb) +static ssize_t handle_aiocb_flush(struct qemu_paiocb *aiocb) { int ret; @@ -176,7 +176,7 @@ qemu_pwritev(int fd, const struct iovec *iov, int nr_iov, off_t offset) #endif -static size_t handle_aiocb_rw_vector(struct qemu_paiocb *aiocb) +static ssize_t handle_aiocb_rw_vector(struct qemu_paiocb *aiocb) { size_t offset = 0; ssize_t len; @@ -199,10 +199,10 @@ static size_t handle_aiocb_rw_vector(struct qemu_paiocb *aiocb) return len; } -static size_t handle_aiocb_rw_linear(struct qemu_paiocb *aiocb, char *buf) +static ssize_t handle_aiocb_rw_linear(struct qemu_paiocb *aiocb, char *buf) { - size_t offset = 0; - size_t len; + ssize_t offset = 0; + ssize_t len; while (offset < aiocb->aio_nbytes) { if (aiocb->aio_type & QEMU_AIO_WRITE) @@ -230,9 +230,9 @@ static size_t handle_aiocb_rw_linear(struct qemu_paiocb *aiocb, char *buf) return offset; } -static size_t handle_aiocb_rw(struct qemu_paiocb *aiocb) +static ssize_t handle_aiocb_rw(struct qemu_paiocb *aiocb) { - size_t nbytes; + ssize_t nbytes; char *buf; if (!(aiocb->aio_type & QEMU_AIO_MISALIGNED)) { @@ -308,7 +308,7 @@ static void *aio_thread(void *unused) while (1) { struct qemu_paiocb *aiocb; - size_t ret = 0; + ssize_t ret = 0; qemu_timeval tv; struct timespec ts; |