summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael S. Tsirkin <mst@redhat.com>2015-03-09 15:59:46 +0100
committerMichael S. Tsirkin <mst@redhat.com>2015-03-11 15:59:57 +0100
commit5820945946b1e221905aa898f2cd97ed825acd47 (patch)
tree5577b869b705370a50e70091982539cd128ed216
parent92bf484a87882aa23f10412c774a7357b9bd2be0 (diff)
downloadhqemu-5820945946b1e221905aa898f2cd97ed825acd47.zip
hqemu-5820945946b1e221905aa898f2cd97ed825acd47.tar.gz
pci/shpc: fix signed integer overflow
clang undefined behaviour sanitizer reports: > hw/pci/shpc.c:162:27: runtime error: left shift of 1 by 31 places > cannot be represented in type 'int' Caused by the usual lack of a 'U' qualifier on a constant 1 being shifted left. Fix it up. Reported-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/pci/shpc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
index 5fd7f4b..759910f 100644
--- a/hw/pci/shpc.c
+++ b/hw/pci/shpc.c
@@ -159,7 +159,7 @@ static void shpc_interrupt_update(PCIDevice *d)
for (slot = 0; slot < shpc->nslots; ++slot) {
uint8_t event = shpc->config[SHPC_SLOT_EVENT_LATCH(slot)];
uint8_t disable = shpc->config[SHPC_SLOT_EVENT_SERR_INT_DIS(d, slot)];
- uint32_t mask = 1 << SHPC_IDX_TO_LOGICAL(slot);
+ uint32_t mask = 1U << SHPC_IDX_TO_LOGICAL(slot);
if (event & ~disable) {
int_locator |= mask;
}
OpenPOWER on IntegriCloud