diff options
author | Gonglei <arei.gonglei@huawei.com> | 2014-10-29 20:49:43 +0800 |
---|---|---|
committer | Paolo Bonzini <pbonzini@redhat.com> | 2014-10-31 11:29:01 +0100 |
commit | 522abf69995ca20680ab048cad003796be36ef77 (patch) | |
tree | cbec0c989f80768a46ad3c88159dd593789cc682 | |
parent | e4dc3f5909ab90520bc1a27b381c3017ff65ed68 (diff) | |
download | hqemu-522abf69995ca20680ab048cad003796be36ef77.zip hqemu-522abf69995ca20680ab048cad003796be36ef77.tar.gz |
vl.c: Fix Coverity complaining for vmstate_dump_file
commit abfd9ce3(migration: dump vmstate info as a json
file for static analysis) introduce a new command,
'-dump-vmstate', that takes a filename
as an argument. When executed, QEMU will dump the vmstate information
for the machine type it's invoked with to the file, and quit.
However, only one instance of the -dump-vmstate option is supported.
If more were given, the vmstate_dump_file variable would be overwritten.
This fix also helps silence a Coverity error.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r-- | vl.c | 5 |
1 files changed, 5 insertions, 0 deletions
@@ -3750,6 +3750,11 @@ int main(int argc, char **argv, char **envp) configure_msg(opts); break; case QEMU_OPTION_dump_vmstate: + if (vmstate_dump_file) { + fprintf(stderr, "qemu: only one '-dump-vmstate' " + "option may be given\n"); + exit(1); + } vmstate_dump_file = fopen(optarg, "w"); if (vmstate_dump_file == NULL) { fprintf(stderr, "open %s: %s\n", optarg, strerror(errno)); |