From 9ef83742d7207c9028cd7382c1cfed526e437e94 Mon Sep 17 00:00:00 2001 From: Stefan Tauner Date: Fri, 3 Feb 2012 22:32:09 +0000 Subject: print*.c: Refine the do not count nor print generic flash chip entries conditions Previously only the generic "unknown XXXX SPI chips" were ignored (because their name started with "unknown". This patch adds also all chips whose vendor starts with "Unknown" (none so far) and "Programmer" (currently used by the opaque flash chip framework) . A patch will add the SFDP chip template with an "Unknown" vendor field later. Rationale: these entries do not contain any useful information when shown in -L or wiki output. It would be better to add them to a general feature section or similar. Corresponding to flashrom svn r1488. Signed-off-by: Stefan Tauner Acked-by: Carl-Daniel Hailfinger --- print.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'print.c') diff --git a/print.c b/print.c index 1ccfff1..c315186 100644 --- a/print.c +++ b/print.c @@ -74,8 +74,10 @@ static void print_supported_chips(void) /* calculate maximum column widths and by iterating over all chips */ for (f = flashchips; f->name != NULL; f++) { - /* Ignore "unknown XXXX SPI chip" entries. */ - if (!strncmp(f->name, "unknown", 7)) + /* Ignore generic entries. */ + if (!strncmp(f->vendor, "Unknown", 7) || + !strncmp(f->vendor, "Programmer", 10) || + !strncmp(f->name, "unknown", 7)) continue; chipcount++; @@ -161,8 +163,10 @@ static void print_supported_chips(void) msg_ginfo("(P = PROBE, R = READ, E = ERASE, W = WRITE)\n\n"); for (f = flashchips; f->name != NULL; f++) { - /* Don't print "unknown XXXX SPI chip" entries. */ - if (!strncmp(f->name, "unknown", 7)) + /* Don't print generic entries. */ + if (!strncmp(f->vendor, "Unknown", 7) || + !strncmp(f->vendor, "Programmer", 10) || + !strncmp(f->name, "unknown", 7)) continue; /* support for multiline vendor names: -- cgit v1.1