summaryrefslogtreecommitdiffstats
path: root/w29ee011.c
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2009-05-16 21:22:56 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2009-05-16 21:22:56 +0000
commit2237dda98204032ae12004f41a99ef9286a28166 (patch)
treea505b6f813fc4f7601f77e7195e479dfddc73571 /w29ee011.c
parentb79140252ae001fb1459010661b2ea8db912fc4c (diff)
downloadflashrom-2237dda98204032ae12004f41a99ef9286a28166.zip
flashrom-2237dda98204032ae12004f41a99ef9286a28166.tar.gz
Use chipaddr instead of volatile uint8_t * because when we access chips in external flashers, they are not accessed via pointers at all
Benefits: This allows us to differentiate between volatile machine memory accesses and flash chip accesses. It also enforces usage of chip_{read,write}[bwl] to access flash chips, so nobody will unintentionally use pointers to access chips anymore. Some unneeded casts are removed as well. Grepping for chip operations and machine memory operations doesn't yield any false positives anymore. Compile tested on 32 bit and 64 bit Linux. Corresponding to flashrom svn r519. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Diffstat (limited to 'w29ee011.c')
-rw-r--r--w29ee011.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/w29ee011.c b/w29ee011.c
index 37b9082..d630440 100644
--- a/w29ee011.c
+++ b/w29ee011.c
@@ -23,7 +23,7 @@
int probe_w29ee011(struct flashchip *flash)
{
- volatile uint8_t *bios = flash->virtual_memory;
+ chipaddr bios = flash->virtual_memory;
uint8_t id1, id2;
extern char *chip_to_probe;
OpenPOWER on IntegriCloud