diff options
author | Stephan Guilloux <stephan.guilloux@free.fr> | 2009-04-25 22:07:28 +0000 |
---|---|---|
committer | Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> | 2009-04-25 22:07:28 +0000 |
commit | 96684c7882dcca26527daeaf53c016b6f9c516fe (patch) | |
tree | 83f4650016474db8df54b0a481288cd997a04257 | |
parent | ae36aba9bf1ee00aa2a1310dded4bd2aa8a1d376 (diff) | |
download | flashrom-96684c7882dcca26527daeaf53c016b6f9c516fe.zip flashrom-96684c7882dcca26527daeaf53c016b6f9c516fe.tar.gz |
The flashrom makefile wants to redirect both stdout and stderr to /dev/null for one compile test
The old variant of using &>/dev/null works on bash and zsh, but not on dash
and tcsh. dash and tcsh interpret it as "background command and truncate
/dev/null" which is not what we want. >& works on tcsh and bash, but it is not
POSIX compliant. Since make uses /bin/sh and /bin/sh has to be POSIX compliant,
we can use the POSIX variant of stderr and stdout redirection. >/dev/null 2>&1
is POSIX compliant. This is specified in SuSv3, Shell Command Language,
sections 2.7.2 and 2.7.6.
Corresponding to flashrom svn r443 and coreboot v2 svn r4211.
Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr>
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ward Vandewege <ward@gnu.org>
-rw-r--r-- | Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -65,7 +65,7 @@ pciutils: echo "struct pci_access *pacc;"; \ echo "int main(int argc, char **argv)"; \ echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c ) - @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \ + @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ echo "found." || ( echo "not found."; echo; \ echo "Please install pciutils-devel and zlib-devel."; \ echo "See README for more information."; echo; \ |