summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-06-04 23:20:21 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-06-04 23:20:21 +0000
commit41fe2c78d422ad892056521848d95cd8cb4588a6 (patch)
treeea4bbb6158dd337b600e537a4b139004c5ff527c
parent9130c5b3892d3b8b6de11dae3d7d4a9421810f5d (diff)
downloadflashrom-41fe2c78d422ad892056521848d95cd8cb4588a6.zip
flashrom-41fe2c78d422ad892056521848d95cd8cb4588a6.tar.gz
Gcc and clang can check format strings of printf-like functions
Since we don't support any other compilers right now, enable that extension unconditionally. Fix the bugs found by format string checking. Corresponding to flashrom svn r1032. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Sean Nelson <audiohacked@gmail.com>
-rw-r--r--flash.h3
-rw-r--r--flashrom.c2
-rw-r--r--udelay.c2
3 files changed, 4 insertions, 3 deletions
diff --git a/flash.h b/flash.h
index 84ee511..cf3bd21 100644
--- a/flash.h
+++ b/flash.h
@@ -591,7 +591,8 @@ int doit(struct flashchip *flash, int force, char *filename, int read_it, int wr
#define NT 1 /* Not tested */
/* cli_output.c */
-int print(int type, const char *fmt, ...);
+/* Let gcc and clang check for correct printf-style format strings. */
+int print(int type, const char *fmt, ...) __attribute__((format(printf, 2, 3)));
#define MSG_ERROR 0
#define MSG_INFO 1
#define MSG_DEBUG 2
diff --git a/flashrom.c b/flashrom.c
index 8a97454..73145a9 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -394,7 +394,7 @@ struct shutdown_func_data {
int register_shutdown(void (*function) (void *data), void *data)
{
if (shutdown_fn_count >= SHUTDOWN_MAXFN) {
- msg_perr("Tried to register more than %n shutdown functions.\n",
+ msg_perr("Tried to register more than %i shutdown functions.\n",
SHUTDOWN_MAXFN);
return 1;
}
diff --git a/udelay.c b/udelay.c
index b395971..8bfba63 100644
--- a/udelay.c
+++ b/udelay.c
@@ -91,7 +91,7 @@ void myusec_calibrate_delay(void)
msg_pinfo("Calibrating delay loop... ");
resolution = measure_os_delay_resolution();
if (resolution) {
- msg_pdbg("OS timer resolution is %u usecs, ", resolution);
+ msg_pdbg("OS timer resolution is %lu usecs, ", resolution);
} else {
msg_pinfo("OS timer resolution is unusable. ");
}
OpenPOWER on IntegriCloud