From e71e65ff1d7e4b70db34aa169556cf77ae25608a Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Wed, 21 Mar 2012 14:39:24 +0100 Subject: lavfi/aspect: check for a negative code from av_parse_ratio() Check on < 0 rather than on != 0, this is more correct as a positive error code from av_parse_ratio() value doesn't mean an error. --- libavfilter/vf_aspect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libavfilter') diff --git a/libavfilter/vf_aspect.c b/libavfilter/vf_aspect.c index 9e3b93b..8a56116 100644 --- a/libavfilter/vf_aspect.c +++ b/libavfilter/vf_aspect.c @@ -37,7 +37,7 @@ static av_cold int init(AVFilterContext *ctx, const char *args, void *opaque) aspect->ratio = (AVRational) {0, 1}; if (args) { - if (av_parse_ratio(&aspect->ratio, args, 100, 0, ctx) || + if (av_parse_ratio(&aspect->ratio, args, 100, 0, ctx) < 0 || aspect->ratio.num < 0 || aspect->ratio.den <= 0) { av_log(ctx, AV_LOG_ERROR, "Invalid string '%s' for aspect ratio.\n", args); -- cgit v1.1