summaryrefslogtreecommitdiffstats
path: root/libavcodec
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-10-23 22:08:37 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-11-09 17:27:19 +0100
commit9ea997395909907f569787d4ba5b96352ad31a80 (patch)
tree04c4cf70a0a902348ad7154a04a6e4aeae82a127 /libavcodec
parent32b3c8ce7d050210d210511cdb8c6644664a70ab (diff)
downloadffmpeg-streaming-9ea997395909907f569787d4ba5b96352ad31a80.zip
ffmpeg-streaming-9ea997395909907f569787d4ba5b96352ad31a80.tar.gz
avcodec/xsubdec: fix overflow in alpha handling
Fixes: left shift of 255 by 24 places cannot be represented in type 'int' Fixes: 18368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XSUB_fuzzer-5702665442426880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/xsubdec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
index 93fd0f4..05c4a64 100644
--- a/libavcodec/xsubdec.c
+++ b/libavcodec/xsubdec.c
@@ -130,7 +130,7 @@ static int decode_frame(AVCodecContext *avctx, void *data, int *data_size,
((uint32_t *)sub->rects[0]->data[1])[i] |= 0xff000000;
} else {
for (i = 0; i < sub->rects[0]->nb_colors; i++)
- ((uint32_t *)sub->rects[0]->data[1])[i] |= *buf++ << 24;
+ ((uint32_t *)sub->rects[0]->data[1])[i] |= (unsigned)*buf++ << 24;
}
#if FF_API_AVPICTURE
OpenPOWER on IntegriCloud