summaryrefslogtreecommitdiffstats
path: root/libavcodec
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2019-10-15 23:42:50 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2019-11-09 15:57:34 +0100
commit0c3e1b395b47fac44397604b2a3343c4bd92561c (patch)
tree42e2c80c6c7171f56683159b6eee328aed147f7f /libavcodec
parent03ea8d8cd45e55eeb9675c38184dc2149710a557 (diff)
downloadffmpeg-streaming-0c3e1b395b47fac44397604b2a3343c4bd92561c.zip
ffmpeg-streaming-0c3e1b395b47fac44397604b2a3343c4bd92561c.tar.gz
avcodec/dstdec: Check that AC probabilities are within range
ISO/IEC 14496-3:2005(E): "Each entry of P_one[ ][ ] is in the range of 1 to 128, corresponding to a probability of 1/256 to 128/256 of the next error bit (bit E, See Figure 10.5)..." Fixes: Timeout (42sec ->1sec) Fixes: 18181/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5736646250594304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
Diffstat (limited to 'libavcodec')
-rw-r--r--libavcodec/dstdec.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/libavcodec/dstdec.c b/libavcodec/dstdec.c
index e0519d2..ae3fe42 100644
--- a/libavcodec/dstdec.c
+++ b/libavcodec/dstdec.c
@@ -162,6 +162,10 @@ static int read_table(GetBitContext *gb, Table *t, const int8_t code_pred_coeff[
c -= (x + 4) / 8;
else
c += (-x + 3) / 8;
+ if (!is_signed) {
+ if (c < offset || c >= offset + (1<<coeff_bits))
+ return AVERROR_INVALIDDATA;
+ }
t->coeff[i][j] = c;
}
}
OpenPOWER on IntegriCloud