diff options
| author | Ben Gardner <gardner.ben@gmail.com> | 2015-12-09 11:17:51 -0600 |
|---|---|---|
| committer | Martin Roth <martinroth@google.com> | 2015-12-16 00:53:48 +0100 |
| commit | 49bbfcd5d393b8c14b46e46f0b20f150e4930b3d (patch) | |
| tree | c17b7e6daf862be183d1ed8a31d8c610deeaef00 | |
| parent | b619f44c67f98e2c93492c643f15be909ca4c99d (diff) | |
| download | coreboot-staging-49bbfcd5d393b8c14b46e46f0b20f150e4930b3d.zip coreboot-staging-49bbfcd5d393b8c14b46e46f0b20f150e4930b3d.tar.gz | |
intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending
The macro PCI_DEV_PIRQ_ROUTE ends with a comma and escaped newline.
Ending a macro with an escaped newline is always wrong.
The final comma is not necessary, as all uses of PCI_DEV_PIRQ_ROUTE()
properly separate calls with a comma.
I haven't investigated whether this is causing a real issue, but it should
be leaving gaps in struct baytrail_irq_route.pcidev.
The non-FSP baytrail does not have this issue.
Change-Id: If6782176068b07cb3bc819c00d1cdb1b618bcea8
Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
Reviewed-on: https://review.coreboot.org/12696
Tested-by: build bot (Jenkins)
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
| -rw-r--r-- | src/soc/intel/fsp_baytrail/acpi/irq_helper.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h index a8cf3ef..8d18aea 100644 --- a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h +++ b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h @@ -85,7 +85,7 @@ Name(prefix_ ## func_ ## A, Package() \ ACPI_DEV_IRQ(dev_, 0, a_), \ ACPI_DEV_IRQ(dev_, 1, b_), \ ACPI_DEV_IRQ(dev_, 2, c_), \ - ACPI_DEV_IRQ(dev_, 3, d_), \ + ACPI_DEV_IRQ(dev_, 3, d_) #define PCIE_BRIDGE_DEV(prefix_, dev_, a_, b_, c_, d_) \ ROOTPORT_IRQ_ROUTES(prefix_, a_, b_, c_, d_) \ |
