From 21816355c00eadb2273d61b456f06239ca300b47 Mon Sep 17 00:00:00 2001 From: Paul Eggleton Date: Fri, 7 Sep 2012 16:22:54 +0100 Subject: bitbake: cooker: fix handling of exceptions during exception handling If an exception occurs during handling another exception we were getting a useless traceback such as the following, after which BitBake froze: ERROR: Command execution failed: Traceback (most recent call last): File "/home/user/poky/poky/bitbake/lib/bb/command.py", line 84, in runAsyncCommand self.cooker.updateCache() File "/home/user/poky/poky/bitbake/lib/bb/cooker.py", line 1207, in updateCache if not self.parser.parse_next(): File "/home/user/poky/poky/bitbake/lib/bb/cooker.py", line 1694, in parse_next logger.error('Unable to parse %s', value.recipe, AttributeError: 'exceptions.TypeError' object has no attribute 'recipe' Fix this to print an actual traceback of the exception and exit gracefully (well, as gracefully as possible under the circumstances). The general fix for [YOCTO #2977]. (Bitbake rev: 675b237a284dff84e972546774b69e2f89afb360) Signed-off-by: Paul Eggleton Signed-off-by: Richard Purdie --- bitbake/lib/bb/cooker.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'bitbake') diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index 1b3bb84..19173ae 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -1691,8 +1691,13 @@ class CookerParser(object): except Exception as exc: self.error += 1 etype, value, tb = sys.exc_info() - logger.error('Unable to parse %s', value.recipe, - exc_info=(etype, value, exc.traceback)) + if hasattr(value, "recipe"): + logger.error('Unable to parse %s', value.recipe, + exc_info=(etype, value, exc.traceback)) + else: + # Most likely, an exception occurred during raising an exception + import traceback + logger.error('Exception during parse: %s' % traceback.format_exc()) self.shutdown(clean=False) return False -- cgit v1.1