summaryrefslogtreecommitdiffstats
path: root/scripts/lib/devtool/standard.py
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2015-03-05 10:51:20 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-03-20 11:27:45 +0000
commitcb4b07838c267a09ebedba6c30ec25bda2cd11be (patch)
treed3c2826f27d23f885631c53dcd6fba4634b4c557 /scripts/lib/devtool/standard.py
parent221705f0143c9ba4c11180dc9ff1bf29966b23bc (diff)
downloadast2050-yocto-poky-cb4b07838c267a09ebedba6c30ec25bda2cd11be.zip
ast2050-yocto-poky-cb4b07838c267a09ebedba6c30ec25bda2cd11be.tar.gz
devtool: modify/extract: prevent usage with incompatible recipes
Consolidate code for checking compatible recipes and consider meta and packagegroup recipes as well as package-index and gcc-source to be incompatible. (From OE-Core rev: 4be9bf637583b341a89af1b9924752abc7d49c94) Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/lib/devtool/standard.py')
-rw-r--r--scripts/lib/devtool/standard.py48
1 files changed, 35 insertions, 13 deletions
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index f9369ee..54920b2 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -87,6 +87,38 @@ def add(args, config, basepath, workspace):
return 0
+def _check_compatible_recipe(pn, d):
+ if pn == 'perf':
+ logger.error("The perf recipe does not actually check out source and thus cannot be supported by this tool")
+ return False
+
+ if pn in ['gcc-source', 'kernel-devsrc', 'package-index']:
+ logger.error("The %s recipe is not supported by this tool" % pn)
+ return False
+
+ if bb.data.inherits_class('image', d):
+ logger.error("The %s recipe is an image, and therefore is not supported by this tool" % pn)
+ return False
+
+ if bb.data.inherits_class('populate_sdk', d):
+ logger.error("The %s recipe is an SDK, and therefore is not supported by this tool" % pn)
+ return False
+
+ if bb.data.inherits_class('packagegroup', d):
+ logger.error("The %s recipe is a packagegroup, and therefore is not supported by this tool" % pn)
+ return False
+
+ if bb.data.inherits_class('meta', d):
+ logger.error("The %s recipe is a meta-recipe, and therefore is not supported by this tool" % pn)
+ return False
+
+ if bb.data.inherits_class('externalsrc', d) and d.getVar('EXTERNALSRC', True):
+ logger.error("externalsrc is currently enabled for the %s recipe. This prevents the normal do_patch task from working. You will need to disable this first." % pn)
+ return False
+
+ return True
+
+
def _get_recipe_file(cooker, pn):
import oe.recipeutils
recipefile = oe.recipeutils.pn_to_recipe(cooker, pn)
@@ -133,16 +165,7 @@ def _extract_source(srctree, keep_temp, devbranch, d):
pn = d.getVar('PN', True)
- if pn == 'perf':
- logger.error("The perf recipe does not actually check out source and thus cannot be supported by this tool")
- return None
-
- if bb.data.inherits_class('image', d):
- logger.error("The %s recipe is an image, and therefore is not supported by this tool" % pn)
- return None
-
- if bb.data.inherits_class('externalsrc', d) and d.getVar('EXTERNALSRC', True):
- logger.error("externalsrc is currently enabled for the %s recipe. This prevents the normal do_patch task from working. You will need to disable this first." % pn)
+ if not _check_compatible_recipe(pn, d):
return None
if os.path.exists(srctree):
@@ -310,9 +333,8 @@ def modify(args, config, basepath, workspace):
return -1
rd = oe.recipeutils.parse_recipe(recipefile, tinfoil.config_data)
- if bb.data.inherits_class('image', rd):
- logger.error("The %s recipe is an image, and therefore is not supported by this tool" % args.recipename)
- return None
+ if not _check_compatible_recipe(args.recipename, rd):
+ return -1
initial_rev = None
commits = []
OpenPOWER on IntegriCloud