summaryrefslogtreecommitdiffstats
path: root/bitbake
diff options
context:
space:
mode:
authorMarcin SmoczyƄski <marcin.smoczynski@enigma.com.pl>2015-04-02 14:24:51 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2015-06-28 09:44:19 +0100
commit5ce20aeb026613f6575dcf6468eeb9a9477c9eae (patch)
treecf02c5fb1ac9e3b4a142abf9c614adc235344ad0 /bitbake
parent9c245f1d7919e5c8109a8f06f02b894e02f61cba (diff)
downloadast2050-yocto-poky-5ce20aeb026613f6575dcf6468eeb9a9477c9eae.zip
ast2050-yocto-poky-5ce20aeb026613f6575dcf6468eeb9a9477c9eae.tar.gz
bitbake: fetch/git: Fix uri in git checkstatus
Pass proper repository url without arguments after a semicolon. Executing checkuri on a rule with git repository in SRC_URI does not report errors when working offline because wrong repository url is passed to the ls-remote command. For example "bitbake -c checkuri glibc" command executes: "git -c core.fsyncobjectfiles=0 ls-remote git://sourceware.org/git/glibc.git;branch=release/2.21/master" command in a shell subprocess to determine if url is valid. Shell subprocess executes in fact 2 commands: "git -c core.fsyncobjectfiles=0 ls-remote git://sourceware.org/git/glibc.git" and "branch=release/2.21/master" First one returns 127 or 128 depending on error but second one returns 0 because it is just env variable setup. Therefore we're not catching connection error. [YOCTO #7558] (Bitbake rev: cb8224f0c73c06879783665e2de39ecca7f6a350) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'bitbake')
-rw-r--r--bitbake/lib/bb/fetch2/git.py3
1 files changed, 1 insertions, 2 deletions
diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index 0fd9bee..ac9d868 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -395,9 +395,8 @@ class Git(FetchMethod):
return ud.revisions[name]
def checkstatus(self, ud, d):
- fetchcmd = "%s ls-remote %s" % (ud.basecmd, ud.url)
try:
- runfetchcmd(fetchcmd, d, quiet=True)
+ self._lsremote(ud, d, "")
return True
except FetchError:
return False
OpenPOWER on IntegriCloud