From 355cbfdbef1fbd41b635a5b92195689fd4d3c0b1 Mon Sep 17 00:00:00 2001 From: Stefan Tauner Date: Sat, 28 May 2011 02:37:14 +0000 Subject: Small fixes - missing spaces in code and output - improved documentation/naming/output - missing line breaks in spi probing functions Corresponding to flashrom svn r1321. Signed-off-by: Stefan Tauner Acked-by: Stefan Tauner --- ichspi.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'ichspi.c') diff --git a/ichspi.c b/ichspi.c index 31945de..299cbf3 100644 --- a/ichspi.c +++ b/ichspi.c @@ -159,9 +159,9 @@ static uint16_t REGREAD8(int X) return mmio_readb(ich_spibar + X); } -#define REGWRITE32(X,Y) mmio_writel(Y, ich_spibar+X) -#define REGWRITE16(X,Y) mmio_writew(Y, ich_spibar+X) -#define REGWRITE8(X,Y) mmio_writeb(Y, ich_spibar+X) +#define REGWRITE32(off,val) mmio_writel(val, ich_spibar+off) +#define REGWRITE16(off,val) mmio_writew(val, ich_spibar+off) +#define REGWRITE8(off,val) mmio_writeb(val, ich_spibar+off) /* Common SPI functions */ static int find_opcode(OPCODES *op, uint8_t opcode); @@ -856,7 +856,8 @@ static int ich_spi_send_command(unsigned int writecnt, unsigned int readcnt, if (!ichspi_lock) opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt); if (opcode_index == -1) { - msg_pdbg("Invalid OPCODE 0x%02x\n", cmd); + msg_pdbg("Invalid OPCODE 0x%02x, will not execute.\n", + cmd); return SPI_INVALID_OPCODE; } } -- cgit v1.1