From 27c3e2dc23b2df8586eafbe6629ee01a4ad6784b Mon Sep 17 00:00:00 2001 From: Peter Stuge Date: Wed, 2 Jul 2008 17:15:47 +0000 Subject: Probe_flash() cleanup for better code readability Corresponding to flashrom svn r291 and coreboot v2 svn r3407. Signed-off-by: Peter Stuge Acked-by: Stefan Reinauer --- flashrom.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) (limited to 'flashrom.c') diff --git a/flashrom.c b/flashrom.c index 63aba1e..f548a91 100644 --- a/flashrom.c +++ b/flashrom.c @@ -102,18 +102,15 @@ int map_flash_registers(struct flashchip *flash) struct flashchip *probe_flash(struct flashchip *flash, int force) { volatile uint8_t *bios; - unsigned long flash_baseaddr, size; + unsigned long flash_baseaddr = 0, size; - while (flash->name != NULL) { - if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0) { - flash++; + for (; flash && flash->name; flash++) { + if (chip_to_probe && strcmp(flash->name, chip_to_probe) != 0) continue; - } printf_debug("Probing for %s %s, %d KB: ", flash->vendor, flash->name, flash->total_size); if (!flash->probe && !force) { printf_debug("failed! flashrom has no probe function for this flash chip.\n"); - flash++; continue; } @@ -150,18 +147,21 @@ struct flashchip *probe_flash(struct flashchip *flash, int force) } flash->virtual_memory = bios; - if (force || flash->probe(flash) == 1) { - printf("Found chip \"%s %s\" (%d KB) at physical address 0x%lx.\n", - flash->vendor, flash->name, flash->total_size, - flash_baseaddr); - return flash; - } - munmap((void *)bios, size); + if (force) + break; - flash++; + if (flash->probe(flash) == 1) + break; + + munmap((void *)bios, size); } - return NULL; + if (!flash || !flash->name) + return NULL; + + printf("Found chip \"%s %s\" (%d KB) at physical address 0x%lx.\n", + flash->vendor, flash->name, flash->total_size, flash_baseaddr); + return flash; } int verify_flash(struct flashchip *flash, uint8_t *buf) -- cgit v1.1