From 42882fd97e404952269e84a762d2304964a72899 Mon Sep 17 00:00:00 2001 From: Carl-Daniel Hailfinger Date: Wed, 22 Apr 2009 13:33:43 +0000 Subject: All "unknown xy SPI chip" entries claim to have status UNTESTED for probe/read/erase/write That is incorrect. A bit of confusion comes from how the #defines are named. We call them TEST_BAD_*, but the message printed by flashrom says: "This flash part has status NOT WORKING for operations:" Something that is unimplemented is definitely not working. Neither of the chip entries mentioned above has erase or write functions implemented, so erase and write are not working. Since their size is unknown, we can't read them in. That means read is not working as well. Probing is a different matter. If a chip-specific probe function had matched, we wouldn't have to handle the chip with the "unknown xy SPI chip" fallback. I'm tempted to call that "not working" as well, but I'm open to discussion on this point. Corresponding to flashrom svn r439 and coreboot v2 svn r4177. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Uwe Hermann --- flashchips.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'flashchips.c') diff --git a/flashchips.c b/flashchips.c index 911457f..bc16b2e 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2167,7 +2167,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2180,7 +2180,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2193,7 +2193,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2206,7 +2206,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2219,7 +2219,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, @@ -2232,7 +2232,7 @@ struct flashchip flashchips[] = { .model_id = GENERIC_DEVICE_ID, .total_size = 0, .page_size = 256, - .tested = TEST_UNTESTED, + .tested = TEST_BAD_PREW, .probe = probe_spi_rdid, .erase = NULL, .write = NULL, -- cgit v1.1