From c6b7dd16890aa63eadd510621e4cd19bb6c5badc Mon Sep 17 00:00:00 2001 From: Stephan Guilloux Date: Sat, 25 Apr 2009 22:07:28 +0000 Subject: The flashrom makefile wants to redirect both stdout and stderr to /dev/null for one compile test The old variant of using &>/dev/null works on bash and zsh, but not on dash and tcsh. dash and tcsh interpret it as "background command and truncate /dev/null" which is not what we want. >& works on tcsh and bash, but it is not POSIX compliant. Since make uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX variant of stderr and stdout redirection. >/dev/null 2>&1 is POSIX compliant. This is specified in SuSv3, Shell Command Language, sections 2.7.2 and 2.7.6. Corresponding to flashrom svn r443 and coreboot v2 svn r4211. Signed-off-by: Stephan Guilloux Signed-off-by: Carl-Daniel Hailfinger Acked-by: Ward Vandewege --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'Makefile') diff --git a/Makefile b/Makefile index cf9570a..4699784 100644 --- a/Makefile +++ b/Makefile @@ -65,7 +65,7 @@ pciutils: echo "struct pci_access *pacc;"; \ echo "int main(int argc, char **argv)"; \ echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c ) - @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \ + @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \ echo "found." || ( echo "not found."; echo; \ echo "Please install pciutils-devel and zlib-devel."; \ echo "See README for more information."; echo; \ -- cgit v1.1