From ab6328fa3615683e5dbba0fffe8707fa0072d035 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Fri, 8 Oct 2010 11:03:02 +0000 Subject: Refine text of requests to send logs A lot of messages sent@flashrom.org just have "flashrom -V" as the subject. Ask people to include more information in the subject line to make life easier for developers/supporters. Corresponding to flashrom svn r1202. Signed-off-by: Paul Menzel Acked-by: Carl-Daniel Hailfinger --- board_enable.c | 7 +++++-- chipset_enable.c | 11 ++++++++--- flashrom.c | 7 ++++--- pcidev.c | 8 +++++--- 4 files changed, 22 insertions(+), 11 deletions(-) diff --git a/board_enable.c b/board_enable.c index 75d8320..9ac6e2d 100644 --- a/board_enable.c +++ b/board_enable.c @@ -433,7 +433,9 @@ int it8705f_write_enable(uint8_t port) max_rom_decode.parallel = 1024 * 1024; msg_pinfo("IT8705F with very unusual settings. Please " "send the output of \"flashrom -V\" to \n" - "flashrom@flashrom.org to help us finish " + "flashrom@flashrom.org with " + "IT8705: your board name: flashrom -V\n" + "as the subject to help us finish " "support for your Super I/O. Thanks.\n"); ret = 1; } else if (tmp & 0x08) { @@ -2097,7 +2099,8 @@ int board_flash_enable(const char *vendor, const char *part) board = NULL; } else { msg_pinfo("NOTE: Running an untested board enable procedure.\n" - "Please report success/failure to flashrom@flashrom.org.\n"); + "Please report success/failure to flashrom@flashrom.org\n" + "with your board name and SUCCESS or FAILURE in the subject.\n"); } } diff --git a/chipset_enable.c b/chipset_enable.c index 9967070..96c240c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -939,7 +939,9 @@ static int enable_flash_mcp6x_7x(struct pci_dev *dev, const char *name) } out_msg: msg_pinfo("Please send the output of \"flashrom -V\" to " - "flashrom@flashrom.org to help us finish support for your " + "flashrom@flashrom.org with\n" + "your board name: flashrom -V as the subject to help us " + "finish support for your\n" "chipset. Thanks.\n"); return ret; @@ -1195,8 +1197,11 @@ int chipset_flash_enable(void) continue; if (ret != -2) { msg_pinfo("WARNING: unexpected second chipset match: " - "\"%s %s\"\nignoring, please report lspci and " - "board URL to flashrom@flashrom.org!\n", + "\"%s %s\"\n" + "ignoring, please report lspci and board URL " + "to flashrom@flashrom.org\n" + "with 2CHIPSET: your board name in the " + "subject line.\n", chipset_enables[i].vendor_name, chipset_enables[i].device_name); continue; diff --git a/flashrom.c b/flashrom.c index fa36bfb..e5e334c 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1314,7 +1314,8 @@ void emergency_help_message(void) { msg_gerr("Your flash chip is in an unknown state.\n" "Get help on IRC at irc.freenode.net (channel #flashrom) or\n" - "mail flashrom@flashrom.org!\n" + "mail flashrom@flashrom.org with FAILED: your board name in " + "the subject line!\n" "-------------------------------------------------------------" "------------------\n" "DO NOT REBOOT OR POWEROFF!\n"); @@ -1496,8 +1497,8 @@ void check_chip_supported(struct flashchip *flash) "operations you tested (-V, -Vr,\n" "-Vw, -VE), and mention which mainboard or " "programmer you tested.\n" - "Thanks for your help!\n" - "===\n"); + "Please mention your board in the subject line. " + "Thanks for your help!\n"); } } diff --git a/pcidev.c b/pcidev.c index 45850e7..4b16db2 100644 --- a/pcidev.c +++ b/pcidev.c @@ -66,9 +66,11 @@ uint32_t pcidev_validate(struct pci_dev *dev, uint32_t bar, if (devs[i].status == NT) { msg_pinfo("===\nThis PCI device is UNTESTED. Please " - "report the 'flashrom -p xxxx' output \n" - "to flashrom@flashrom.org if it works " - "for you. Thank you for your help!\n===\n"); + "report the 'flashrom -p xxxx' output \n" + "to flashrom@flashrom.org if it works " + "for you. Please add the name of your\n" + "PCI device to the subject. Thank you for " + "your help!\n===\n"); } return addr; -- cgit v1.1