From 907c3eb800a04c6266d1dae519cba2ba46de8f49 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Sat, 26 Apr 2014 16:12:31 +0000 Subject: CID1129996: Unchecked return value from setsockopt() in serprog Corresponding to flashrom svn r1777. Signed-off-by: Stefan Reinauer Acked-by: Stefan Tauner --- serprog.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/serprog.c b/serprog.c index 86c67e0..35c4f32 100644 --- a/serprog.c +++ b/serprog.c @@ -115,7 +115,11 @@ static int sp_opensocket(char *ip, unsigned int port) } /* We are latency limited, and sometimes do write-write-read * * (write-n) - so enable TCP_NODELAY. */ - setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(int)); + if (setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof(int))) { + close(sock); + msg_perr("Error: serprog cannot set socket options: %s\n", strerror(errno)); + return -1; + } return sock; } #endif -- cgit v1.1