summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Convert all flashchips.c entries with SPI programing to the 256-byte version ↵Carl-Daniel Hailfinger2009-05-093-59/+59
| | | | | | | | | | | | | by default Change the flashchips entry for SST SST25VF080B to 1-byte writing. Tested-by: Ali Nadalizadeh. Corresponding to flashrom svn r486. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Chips like the SST SST25VF080B can only handle single byte writes outside ↵Carl-Daniel Hailfinger2009-05-096-16/+50
| | | | | | | | | | | | | | | | | | AAI mode Change SPI architecture to handle 1-byte chunk chip writing differently from 256-byte chunk chip writing. Annotate SPI chip write functions with _256 or _1 suffix denoting the number of bytes they write at maximum. The 1-byte chunk writing is cut-n-pasted to different SPI drivers right now. A later patch can move them to the generic spi_chip_write_1. Corresponding to flashrom svn r485. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Refine handling of spi_write_enable() failures to fix chip erases on ichspiCarl-Daniel Hailfinger2009-05-094-16/+54
| | | | | | | | | | | | | | | Until the ICH SPI driver can handle preopcodes as standalone opcodes, we should handle such special opcode failure gracefully on ICH and compatible chipsets. This fixes chip erase on almost all ICH+VIA SPI masters. Thanks to Ali Nadalizadeh for helping track down this bug! Corresponding to flashrom svn r484. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Add a dummy external flasher which just prints each operationCarl-Daniel Hailfinger2009-05-095-2/+104
| | | | | | | | | | | | Usage: flashrom --programmer dummy This is a great way to test flashrom without root access. Corresponding to flashrom svn r483. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* board_enable: split vendor name and board name into two fieldsUwe Hermann2009-05-091-42/+47
| | | | | | | | | | This will allow generation of supported boards for wiki output to be split to distinct columns. Corresponding to flashrom svn r482. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Add --programmer to help text and man pageCarl-Daniel Hailfinger2009-05-092-0/+6
| | | | | | | Corresponding to flashrom svn r481. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Make chipset list alphabetically ordered as the other listsUwe Hermann2009-05-081-39/+40
| | | | | | | Corresponding to flashrom svn r477. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Add external flasher supportCarl-Daniel Hailfinger2009-05-084-91/+233
| | | | | | | | | | | | | | | | | - Read/write accesses through function pointers - Command line parameter for internal/external flasher - Board and chipset setup moved to internal init function - Shutdown stuff moved to internal shutdown function As a side benefit, this will allow us to undo chipset write enable during shutdown. Tested by Uwe on real hardware. Corresponding to flashrom svn r476. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Re-add a line which got deleted in r473 by accidentCarl-Daniel Hailfinger2009-05-081-0/+2
| | | | | | | Corresponding to flashrom svn r475. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Keep list of boards alphabetically sortedUwe Hermann2009-05-081-20/+21
| | | | | | | | | | This is (among other things) useful/required for the -L output and the upcoming wiki-syntax output of supported boards. Corresponding to flashrom svn r474. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Don't assume flash is accessible via MMIO for chips with no read functionCarl-Daniel Hailfinger2009-05-083-13/+134
| | | | | | | | | | | | | | | | Flashrom assumes that the flash chip contents are available via mmap if no read function is defined. This special case is handled in lots of places all over the code. Remove the special case and use the read_memmapped function. Not only does this allow us to fix a read bug in flashrom I recently uncovered on ICH SPI, it also allows us to add support for Paraflasher to flashrom. Corresponding to flashrom svn r473. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Store and display chipset test status (not only chip status)Uwe Hermann2009-05-071-83/+91
| | | | | | | | | | | | The list of tested chipsets is synced from the wiki. Also, split the chipset vendor and name into two fields for easier wiki-syntax output later. Corresponding to flashrom svn r472. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Always print the flashrom version as first output lineCarl-Daniel Hailfinger2009-05-071-1/+3
| | | | | | | | | Suggested by Peter Stuge. Corresponding to flashrom svn r471. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Document uncertainty regarding ASD chipsCarl-Daniel Hailfinger2009-05-061-0/+1
| | | | | | | | | | | ASD chips may exist, but all available docs suggest they are just rebranded Winbond chips with Winbond IDs. The ASD vendor/chip IDs in flash.h are very likely just misinterpreted LHA headers. Corresponding to flashrom svn r470. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Clarify error message in enable_flash_sb600() a littlePeter Stuge2009-05-061-1/+1
| | | | | | | Corresponding to flashrom svn r469. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Improve SST25 status register routinesCarl-Daniel Hailfinger2009-05-061-11/+15
| | | | | | | | | | | | - Using a 4-bit index into an array with 8 elements leads to out-of-bounds accesses. Use proper bit masking to fix this. - Factor out common SST25 status register printing. - Use the common SST25 status register printing for SST25VF080B. Corresponding to flashrom svn r468. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Peter Stuge <peter@stuge.se>
* Revert r466 because of inverted logicCarl-Daniel Hailfinger2009-05-061-5/+6
| | | | | | | | | If unprotect succeeded, it will print "SB600 unprotect failed". Corresponding to flashrom svn r467. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Cleanup redundant condition and clarify message a littlePeter Stuge2009-05-061-6/+5
| | | | | | | Corresponding to flashrom svn r466. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Touch up some error messages in enable_flash_cs5536()Peter Stuge2009-05-061-2/+2
| | | | | | | Corresponding to flashrom svn r465. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Clean up the SB400 chipset enable codeCarl-Daniel Hailfinger2009-05-061-9/+1
| | | | | | | | | | Use pci_dev_find() instead of setting up a filter and iterating over PCI devices. Corresponding to flashrom svn r464. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Stefan Reinauer <stepan@coresystems.de>
* Rewrite the SB600 chipset enable functionCarl-Daniel Hailfinger2009-05-051-17/+33
| | | | | | | | | | | | | | | | - Check for read/write protected regions first. - Region protection is write-once according to the data sheets. Check if the write succeeded. Don't write if the region is not protected. - Verbose region protection dumping. - Improve readability of BAR mapping code. - Align BAR mapping to a page boundary (4k) instead of a 16k boundary. This patch prepares the code for a SPI detection heuristic. Corresponding to flashrom svn r463. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Peter Stuge <peter@stuge.se>
* Here is a fix for chipset_enable.c when there is not /dev/cpuBertrand Jacquin2009-05-051-1/+1
| | | | | | | | | | Open fails so there is no reason to lseek in. Actually this is a trivial fix for a bad return value from open. Corresponding to flashrom svn r462. Signed-off-by: Bertrand Jacquin <beber@meleeweb.net> Acked-by: Ronald G. Minnich <rminnich@gmail.com>
* SST25VF080B TEST_OK_ ERASE WRITEPeter Stuge2009-05-051-1/+1
| | | | | | | | | As reported by A. Spamlover. Thanks! Corresponding to flashrom svn r461. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Some cosmetics in README and manpageUwe Hermann2009-05-052-57/+68
| | | | | | | | | | Also, move more stuff to the manpage where it belongs (this also eliminates some duplicated contents). Corresponding to flashrom svn r460. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Force enabling SPI mode for SB600 is a bad idea and leads to hangsZheng Bao2009-05-041-0/+8
| | | | | | | | | | | | Only access LPC ROM if we boot via LPC ROM. Only access SPI ROM if we boot via SPI ROM. The code to force enable SPI is commented out in case someone wants to reenable it for a particular board with LPC and SPI flash. Corresponding to flashrom svn r459. Signed-off-by: Zheng Bao <zheng.bao@amd.com> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* SST25VF080B TEST_OK_READPeter Stuge2009-05-041-1/+1
| | | | | | | | | Per report from from Henning Fleddermann. Thanks! Corresponding to flashrom svn r458. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Onwards with developmentCarl-Daniel Hailfinger2009-05-041-2/+4
| | | | | | | | | Re-add the svn revision to the version string. Corresponding to flashrom svn r457. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Flashrom 0.9.0Carl-Daniel Hailfinger2009-05-042-5/+3
| | | | | | | Corresponding to flashrom svn r454. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Peter Stuge <peter@stuge.se>
* Complement the README file with build instructions for the platforms it ↵Idwer Vollering2009-05-031-1/+10
| | | | | | | | | currently compiles on Corresponding to flashrom svn r453. Signed-off-by: Idwer Vollering <vidwer@gmail.com> Acked-by: Peter Stuge <peter@stuge.se>
* Allow compilation on SolarisCarl-Daniel Hailfinger2009-05-013-7/+29
| | | | | | | | | | | | Fix compilation on Solaris and tell people how to compile flashrom on Solaris, Darwin/Mac OS X and DragonFly BSD. Thanks to Joerg Schilling and Patrick Georgi for the Solaris part. Corresponding to flashrom svn r452. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Peter Stuge <peter@stuge.se>
* Mention that flashrom can also verify flash contentsPeter Stuge2009-05-012-4/+4
| | | | | | | Corresponding to flashrom svn r451. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Fix usage to show that vendor: is optional in the -m parameterPeter Stuge2009-05-011-1/+1
| | | | | | | Corresponding to flashrom svn r450. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Some functions take no argumentsCarl-Daniel Hailfinger2009-05-011-5/+5
| | | | | | | | | | Make that explicit in the associated prototypes. This avoids a warning on some compilers and is a correctness issue. Corresponding to flashrom svn r449. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Add Li-Ta (Ollie) Lo to the author listCarl-Daniel Hailfinger2009-05-011-0/+2
| | | | | | | | | | | He started flashrom back in 2000. Thanks to Ron for pointing this out. Corresponding to flashrom svn r448. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Since the command line interface for flashrom will change for 1.0Carl-Daniel Hailfinger2009-05-012-0/+9
| | | | | | | | | | (all-caps or no-caps for short options, exclude range syntax, etc.) we should tell users in the man page and the usage message about this. Corresponding to flashrom svn r447. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Macronix MX25L1605 TEST_OK_ PROBE READ ERASE WRITEPeter Stuge2009-04-291-1/+1
| | | | | | | | | Per report from Aldrik Dunbar. Thanks! Corresponding to flashrom svn r446. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* Handle DragonFly BSD definitions in flash.hPatrick Georgi2009-04-282-3/+3
| | | | | | | | | | | There are still some tweaks necessary to get flashrom to build on DragonFly, but this helps a lot. Corresponding to flashrom svn r445. Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de> Acked-by: Stefan Reinauer <stepan@coresystems.de> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* Enable scan-build for flashromPatrick Georgi2009-04-261-2/+2
| | | | | | | Corresponding to flashrom svn r444. Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de> Acked-by: Patrick Georgi <patrick.georgi@coresystems.de>
* The flashrom makefile wants to redirect both stdout and stderr to /dev/null ↵Stephan Guilloux2009-04-251-1/+1
| | | | | | | | | | | | | | | | | | | | | for one compile test The old variant of using &>/dev/null works on bash and zsh, but not on dash and tcsh. dash and tcsh interpret it as "background command and truncate /dev/null" which is not what we want. >& works on tcsh and bash, but it is not POSIX compliant. Since make uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX variant of stderr and stdout redirection. >/dev/null 2>&1 is POSIX compliant. This is specified in SuSv3, Shell Command Language, sections 2.7.2 and 2.7.6. Corresponding to flashrom svn r443 and coreboot v2 svn r4211. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Ward Vandewege <ward@gnu.org>
* MAX may already be definedUwe Hermann2009-04-242-5/+5
| | | | | | | | | Also, fix smaller cosmetics Corresponding to flashrom svn r442 and coreboot v2 svn r4205. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Support MX25L3235DStephan Guilloux2009-04-232-1/+15
| | | | | | | Corresponding to flashrom svn r441 and coreboot v2 svn r4200. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Acked-by: Peter Stuge <peter@stuge.se>
* Don't duplicate option description in README, the manpage already has that infoUwe Hermann2009-04-232-26/+5
| | | | | | | | | Also, additional small cosmetic fix. Corresponding to flashrom svn r440 and coreboot v2 svn r4196. Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* All "unknown xy SPI chip" entries claim to have status UNTESTED for ↵Carl-Daniel Hailfinger2009-04-221-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | probe/read/erase/write That is incorrect. A bit of confusion comes from how the #defines are named. We call them TEST_BAD_*, but the message printed by flashrom says: "This flash part has status NOT WORKING for operations:" Something that is unimplemented is definitely not working. Neither of the chip entries mentioned above has erase or write functions implemented, so erase and write are not working. Since their size is unknown, we can't read them in. That means read is not working as well. Probing is a different matter. If a chip-specific probe function had matched, we wouldn't have to handle the chip with the "unknown xy SPI chip" fallback. I'm tempted to call that "not working" as well, but I'm open to discussion on this point. Corresponding to flashrom svn r439 and coreboot v2 svn r4177. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
* Add support for Gigabyte GA-MA790FX-DQ6Carl-Daniel Hailfinger2009-04-211-0/+2
| | | | | | | | | | | This board uses IT8718F LPC->SPI translation for the flash chip. Tested by Mateusz Murawski. Corresponding to flashrom svn r438 and coreboot v2 svn r4161. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Mateusz Murawski <matowy@tlen.pl>
* Support Macronix MX2512805D flash chipStephan Guilloux2009-04-212-0/+15
| | | | | | | Corresponding to flashrom svn r437 and coreboot v2 svn r4150. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Acked-by: Peter Stuge <peter@stuge.se>
* Trivial indent fixStephan Guilloux2009-04-211-1/+1
| | | | | | | Corresponding to flashrom svn r436 and coreboot v2 svn r4149. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Acked-by: Peter Stuge <peter@stuge.se>
* After verification in datasheets, all MX25 accept the same opcodes 0x60 and ↵Stephan Guilloux2009-04-201-7/+8
| | | | | | | | | 0xC7 for Chip Erase Corresponding to flashrom svn r435 and coreboot v2 svn r4146. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
* board_enables: reconstruct tableLuc Verhaegen2009-04-201-421/+43
| | | | | | | | | | | | | This patch restores the pciid based board matching table. It makes this table readable and hackable again, and the only disadvantage is that the right margin is way beyond the rather dogmatic 80. All 0x0000 pci ids have been string replaced by 0 to more easily spot missing ids, and extra comments have been added to explain how the various entries are used. Corresponding to flashrom svn r434 and coreboot v2 svn r4142. Signed-off-by: Luc Verhaegen <libv@skynet.be> Acked-by: Peter Stuge <peter@stuge.se>
* Trivial README change Flashrom->flashromPeter Stuge2009-04-201-5/+5
| | | | | | | Corresponding to flashrom svn r433 and coreboot v2 svn r4141. Signed-off-by: Peter Stuge <peter@stuge.se> Acked-by: Peter Stuge <peter@stuge.se>
* MX25L1605 and 1635 accept Chip Erase opcodes 60 and C7Stephan Guilloux2009-04-191-2/+2
| | | | | | | Corresponding to flashrom svn r432 and coreboot v2 svn r4139. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Acked-by: Peter Stuge <peter@stuge.se>
OpenPOWER on IntegriCloud