path: root/sst_fwhub.c
diff options
authorCarl-Daniel Hailfinger <>2009-03-05 19:24:22 +0000
committerCarl-Daniel Hailfinger <>2009-03-05 19:24:22 +0000
commit61a8bd27fb5ff27db98e96b462957994e7cca946 (patch)
tree42326fb1bdeb491df1db567eacdec088bee46c7d /sst_fwhub.c
parent0677dfffc67ad2d0e973f558be86e66f225b4ddc (diff)
Use helper functions to access flash chips
Right now we perform direct pointer manipulation without any abstraction to read from and write to memory mapped flash chips. That makes it impossible to drive any flasher which does not mmap the whole chip. Using helper functions readb() and writeb() allows a driver for external flash programmers like Paraflasher to replace readb and writeb with calls to its own chip access routines. This patch has the additional advantage of removing lots of unnecessary casts to volatile uint8_t * and now-superfluous parentheses which caused poor readability. I used the semantic patcher Coccinelle to create this patch. The semantic patch follows: @@ expression a; typedef uint8_t; volatile uint8_t *b; @@ - *(b) = (a); + writeb(a, b); @@ volatile uint8_t *b; @@ - *(b) + readb(b) @@ type T; T b; @@ ( readb | writeb ) (..., - (T) - (b) + b ) In contrast to a sed script, the semantic patch performs type checking before converting anything. Tested-by: Joe Julian Corresponding to flashrom svn r418 and coreboot v2 svn r3971. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: FENG Yu Ning <>
Diffstat (limited to 'sst_fwhub.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/sst_fwhub.c b/sst_fwhub.c
index 455107e..2c2992e 100644
--- a/sst_fwhub.c
+++ b/sst_fwhub.c
@@ -51,7 +51,7 @@ int erase_sst_fwhub_block(struct flashchip *flash, int offset)
volatile uint8_t *wrprotect = flash->virtual_registers + offset + 2;
// clear write protect
- *(wrprotect) = 0;
+ writeb(0, wrprotect);
erase_block_jedec(flash->virtual_memory, offset);
OpenPOWER on IntegriCloud