path: root/spi.h
diff options
authorPeter Stuge <>2008-07-07 06:38:51 +0000
committerPeter Stuge <>2008-07-07 06:38:51 +0000
commitf83221b6db1a35b559830c01fe40cdb4fa3f5fb2 (patch)
tree83dc53759cd8cca1419c8e1e43dc3e83d15995f2 /spi.h
parent6a214163c098f63a2fc3595d69f41b1cab0e64c9 (diff)
Trivial SPI cleanups
While writing a new SPI driver I fixed some things in the SPI code: All calls to spi_command() had unneccessary #define duplications, and in some cases the read count define could theoretically become harmful because NULL was passed for the read buffer. Avoid a crash, should someone change the #defines. I also noticed that the only caller of spi_page_program() was the it87 driver, and spi_page_program() could only call back into the it87 driver. Removed the function for easier-to-follow code and made it8716f_spi_page_program() static. The ichspi driver's static page functions are already static. Corresponding to flashrom svn r302 and coreboot v2 svn r3418. Signed-off-by: Peter Stuge <> Acked-by: Peter Stuge <>
Diffstat (limited to 'spi.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/spi.h b/spi.h
index f5c877c..429ca6f 100644
--- a/spi.h
+++ b/spi.h
@@ -49,7 +49,7 @@
#define JEDEC_CE_60_OUTSIZE 0x01
#define JEDEC_CE_60_INSIZE 0x00
-/* Chip Erase 0xc7 is supported by ST/EON/Macronix chips. */
+/* Chip Erase 0xc7 is supported by SST/ST/EON/Macronix chips. */
#define JEDEC_CE_C7 0xc7
#define JEDEC_CE_C7_OUTSIZE 0x01
#define JEDEC_CE_C7_INSIZE 0x00
OpenPOWER on IntegriCloud