summaryrefslogtreecommitdiffstats
path: root/sharplhf00l04.c
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-10-10 14:02:27 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2010-10-10 14:02:27 +0000
commitb30a5ed4afead1592224009230ea23500f91b230 (patch)
tree0185573277197cab68874cedd1e00246ea2cf573 /sharplhf00l04.c
parentb28349f8bc40dd55524113e258b3185711e80366 (diff)
downloadast2050-flashrom-b30a5ed4afead1592224009230ea23500f91b230.zip
ast2050-flashrom-b30a5ed4afead1592224009230ea23500f91b230.tar.gz
Unify chip write functions
The currently used write functions (wrappers) all use helpers which perform the actual write (inner functions). The signature of the write wrappers is: int write_chip(struct flashchip *flash, uint8_t * buf); The signature of the inner write functions varied a lot. This patch changes them to: int write_part(struct flashchip *flash, uint8_t *src, int start, int len); Did you know that flashrom has only 8 inner write functions for all flash chips? write_page_write_jedec_common write_sector_jedec_common write_sector_28sf040 spi_chip_write_256_new spi_chip_write_1_new spi_aai_write_new write_page_82802ab write_page_m29f400bt Export all inner write functions. Change the function signature of wait_82802ab to eliminate single-use variables. Remove an error message in write_page_m29f400bt which was printed for every byte written regardless of success. Add sharplhf00l04.c to the list of flash chip drivers in the Makefile. While the functions in there are unused, I suspect we will need them later, and by hooking the file up we ensure that compilation won't break. Corresponding to flashrom svn r1208. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Diffstat (limited to 'sharplhf00l04.c')
-rw-r--r--sharplhf00l04.c9
1 files changed, 4 insertions, 5 deletions
diff --git a/sharplhf00l04.c b/sharplhf00l04.c
index d291573..bb3e359 100644
--- a/sharplhf00l04.c
+++ b/sharplhf00l04.c
@@ -23,6 +23,7 @@
/* FIXME: The datasheet is unclear whether we should use toggle_ready_jedec
* or wait_82802ab.
+ * FIXME: This file is unused.
*/
int erase_lhf00l04_block(struct flashchip *flash, unsigned int blockaddr, unsigned int blocklen)
@@ -33,7 +34,7 @@ int erase_lhf00l04_block(struct flashchip *flash, unsigned int blockaddr, unsign
// clear status register
chip_writeb(0x50, bios);
- status = wait_82802ab(flash->virtual_memory);
+ status = wait_82802ab(flash);
print_status_82802ab(status);
// clear write protect
msg_cspew("write protect is at 0x%lx\n", (wrprotect));
@@ -46,7 +47,7 @@ int erase_lhf00l04_block(struct flashchip *flash, unsigned int blockaddr, unsign
chip_writeb(0xd0, bios);
programmer_delay(10);
// now let's see what the register is
- status = wait_82802ab(flash->virtual_memory);
+ status = wait_82802ab(flash);
print_status_82802ab(status);
if (check_erased_range(flash, blockaddr, blocklen)) {
@@ -61,11 +62,9 @@ int write_lhf00l04(struct flashchip *flash, uint8_t *buf)
int i;
int total_size = flash->total_size * 1024;
int page_size = flash->page_size;
- chipaddr bios = flash->virtual_memory;
for (i = 0; i < total_size / page_size; i++) {
- write_page_82802ab(bios, buf + i * page_size,
- bios + i * page_size, page_size);
+ write_page_82802ab(flash, buf + i * page_size, i * page_size, page_size);
}
return 0;
OpenPOWER on IntegriCloud