summaryrefslogtreecommitdiffstats
path: root/jedec.c
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2012-10-27 15:36:56 +0000
committerStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2012-10-27 15:36:56 +0000
commit78ffbeaa029fb827dcdf9c02262adbda4673e5eb (patch)
tree0a53b1a2841c62239d491c2341f41d073e6d9cbb /jedec.c
parent92fefc921a602acb89a897193c9f31fbb78d85b5 (diff)
downloadast2050-flashrom-78ffbeaa029fb827dcdf9c02262adbda4673e5eb.zip
ast2050-flashrom-78ffbeaa029fb827dcdf9c02262adbda4673e5eb.tar.gz
Do not read the flash chip twice in verification mode
Kyösti Mälkki noticed that we unnecessarily read the flash chip twice when called with --verify. The first one is the mandatory read before everything (to be able to detect the seriousness of errors), but the second one is not necessary because we can just use the former for the comparison. This introduces a small output change: previously we printed ERASE or VERIFY depending on the callee. This special case has been dropped because it is unnecessary to print it (and wrong for the verification function to need to know why it is verifying exactly). If an erase fails we mention that fact explicitly already, similar for verify. Corresponding to flashrom svn r1619. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Diffstat (limited to 'jedec.c')
-rw-r--r--jedec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/jedec.c b/jedec.c
index d8532c6..7bc9133 100644
--- a/jedec.c
+++ b/jedec.c
@@ -410,7 +410,7 @@ retry:
dst = d;
src = s;
- failed = verify_range(flash, src, start, page_size, NULL);
+ failed = verify_range(flash, src, start, page_size);
if (failed && tried++ < MAX_REFLASH_TRIES) {
msg_cerr("retrying.\n");
OpenPOWER on IntegriCloud