summaryrefslogtreecommitdiffstats
path: root/it85spi.c
diff options
context:
space:
mode:
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2011-08-15 19:54:20 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2011-08-15 19:54:20 +0000
commit082c8b559cd9f3262c9af58ac2f17f2cc8a09d8b (patch)
treece63847ee6cc1e63289e3f658a5d57ebd35b3619 /it85spi.c
parent0528b7fefa6daf35365c1dee0d21bc94e8120f78 (diff)
downloadast2050-flashrom-082c8b559cd9f3262c9af58ac2f17f2cc8a09d8b.zip
ast2050-flashrom-082c8b559cd9f3262c9af58ac2f17f2cc8a09d8b.tar.gz
Fixup of r1397
- Mixing uninitialized and initialized local variables leads to confusion. - ft2232_spi error cases should have gotten some error handling, and that's the reason the curly braces were there. - Fixing typos/wording in some places would have been nice given that those places were touched anyway. Corresponding to flashrom svn r1413. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Diffstat (limited to 'it85spi.c')
-rw-r--r--it85spi.c17
1 files changed, 9 insertions, 8 deletions
diff --git a/it85spi.c b/it85spi.c
index 76e4861..f1ad22b 100644
--- a/it85spi.c
+++ b/it85spi.c
@@ -84,15 +84,15 @@ unsigned char *ce_high, *ce_low;
static int it85xx_scratch_rom_reenter = 0;
/* This function will poll the keyboard status register until either
- * an expected value shows up, or
- * timeout reaches.
+ * an expected value shows up, or the timeout is reached.
+ * timeout is in usec.
*
- * Returns: 0 -- the expected value has shown.
- * 1 -- timeout reached.
+ * Returns: 0 -- the expected value showed up.
+ * 1 -- timeout.
*/
static int wait_for(const unsigned int mask, const unsigned int expected_value,
- const int timeout /* in usec */, const char *error_message,
- const char *function_name, const int lineno)
+ const int timeout, const char * error_message,
+ const char * function_name, const int lineno)
{
int time_passed;
@@ -317,8 +317,9 @@ static int it85xx_spi_send_command(unsigned int writecnt, unsigned int readcnt,
int i;
it85xx_enter_scratch_rom();
- /* exit scratch ROM ONLY when programmer shuts down. Otherwise, the
- * temporary flash state may halt EC. */
+ /* Exit scratch ROM ONLY when programmer shuts down. Otherwise, the
+ * temporary flash state may halt the EC.
+ */
#ifdef LPC_IO
INDIRECT_A1(shm_io_base, (((unsigned long int)ce_high) >> 8) & 0xff);
OpenPOWER on IntegriCloud