path: root/ichspi.c
diff options
authorCarl-Daniel Hailfinger <>2009-05-13 11:40:08 +0000
committerCarl-Daniel Hailfinger <>2009-05-13 11:40:08 +0000
commit3e9dbea1ce9c94a879deccc48bd72c60eb4b3454 (patch)
tree507387aa6b99ba2538d054a6662233927750ba19 /ichspi.c
parentb4dcb7188ff557c6722f862a61e806f901c17889 (diff)
There are various reasons why a SPI command can fail
Among others, I have seen the following problems: - The SPI opcode is not supported by the controller. ICH-style controllers exhibit this if SPI config is locked down. - The address in in a prohibited area. This can happen on ICH for any access (BBAR) and for writes in chipset write protected areas. - There is no SPI controller. Introduce separate error codes for unsupported opcode and prohibited address. Add the ability to adjust REMS and RES addresses to the minium supported read address with the help of spi_get_valid_read_addr(). That function needs to call SPI controller specific functions like reading BBAR on ICH. Corresponding to flashrom svn r500. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Uwe Hermann <>
Diffstat (limited to 'ichspi.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/ichspi.c b/ichspi.c
index ea80795..a3bb184 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -767,7 +767,7 @@ int ich_spi_command(unsigned int writecnt, unsigned int readcnt,
/* unknown / not programmed command */
if (opcode_index == -1) {
printf_debug("Invalid OPCODE 0x%02x\n", cmd);
- return 1;
opcode = &(curopcodes->opcode[opcode_index]);
OpenPOWER on IntegriCloud