summaryrefslogtreecommitdiffstats
path: root/ichspi.c
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2011-05-28 02:37:14 +0000
committerStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2011-05-28 02:37:14 +0000
commit355cbfdbef1fbd41b635a5b92195689fd4d3c0b1 (patch)
treebf90deeafdc4ff48c7778e0f48e716befa48cf7c /ichspi.c
parent0fbba98c27433c97f42936e9e16805089ce3a296 (diff)
downloadast2050-flashrom-355cbfdbef1fbd41b635a5b92195689fd4d3c0b1.zip
ast2050-flashrom-355cbfdbef1fbd41b635a5b92195689fd4d3c0b1.tar.gz
Small fixes
- missing spaces in code and output - improved documentation/naming/output - missing line breaks in spi probing functions Corresponding to flashrom svn r1321. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Diffstat (limited to 'ichspi.c')
-rw-r--r--ichspi.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/ichspi.c b/ichspi.c
index 31945de..299cbf3 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -159,9 +159,9 @@ static uint16_t REGREAD8(int X)
return mmio_readb(ich_spibar + X);
}
-#define REGWRITE32(X,Y) mmio_writel(Y, ich_spibar+X)
-#define REGWRITE16(X,Y) mmio_writew(Y, ich_spibar+X)
-#define REGWRITE8(X,Y) mmio_writeb(Y, ich_spibar+X)
+#define REGWRITE32(off,val) mmio_writel(val, ich_spibar+off)
+#define REGWRITE16(off,val) mmio_writew(val, ich_spibar+off)
+#define REGWRITE8(off,val) mmio_writeb(val, ich_spibar+off)
/* Common SPI functions */
static int find_opcode(OPCODES *op, uint8_t opcode);
@@ -856,7 +856,8 @@ static int ich_spi_send_command(unsigned int writecnt, unsigned int readcnt,
if (!ichspi_lock)
opcode_index = reprogram_opcode_on_the_fly(cmd, writecnt, readcnt);
if (opcode_index == -1) {
- msg_pdbg("Invalid OPCODE 0x%02x\n", cmd);
+ msg_pdbg("Invalid OPCODE 0x%02x, will not execute.\n",
+ cmd);
return SPI_INVALID_OPCODE;
}
}
OpenPOWER on IntegriCloud