path: root/flashrom.c
diff options
authorCarl-Daniel Hailfinger <>2009-06-13 12:04:03 +0000
committerCarl-Daniel Hailfinger <>2009-06-13 12:04:03 +0000
commit38a059d6ef1ebb7145a04825fec0ebef1d8a66a7 (patch)
tree66c9108eda2f0f7129f2ba55b9cb757414d9466a /flashrom.c
parent8b2f46b878a952a0ea0869624636cb4d6f5fa8c1 (diff)
Every SPI host controller implemented its own way to read flash chips
This was partly due to a design problem in the abstraction layer. There should be exactly two different functions for reading SPI chips: - memory mapped reads - SPI command reads. Each of them should be contained in a separate function, optionally taking parameters where needed. This patch solves the problems mentioned above, shortens the code and makes the code logic a lot more obvious. Since open-coding the min() function leads to errors, include it in this patch as well. Corresponding to flashrom svn r589. Signed-off-by: Carl-Daniel Hailfinger <> Acked-by: Ronald G. Minnich <>
Diffstat (limited to 'flashrom.c')
1 files changed, 5 insertions, 0 deletions
diff --git a/flashrom.c b/flashrom.c
index 7c3c7f3..f35e9b0 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -200,6 +200,11 @@ int read_memmapped(struct flashchip *flash, uint8_t *buf)
return 0;
+int min(int a, int b)
+ return (a < b) ? a : b;
char *strcat_realloc(char *dest, const char *src)
dest = realloc(dest, strlen(dest) + strlen(src) + 1);
OpenPOWER on IntegriCloud