summaryrefslogtreecommitdiffstats
path: root/Makefile
diff options
context:
space:
mode:
authorStephan Guilloux <stephan.guilloux@free.fr>2009-04-25 22:07:28 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>2009-04-25 22:07:28 +0000
commitc6b7dd16890aa63eadd510621e4cd19bb6c5badc (patch)
tree83f4650016474db8df54b0a481288cd997a04257 /Makefile
parentad216bf3a023569249069ec6dc5c93fd7bd741d7 (diff)
downloadast2050-flashrom-c6b7dd16890aa63eadd510621e4cd19bb6c5badc.zip
ast2050-flashrom-c6b7dd16890aa63eadd510621e4cd19bb6c5badc.tar.gz
The flashrom makefile wants to redirect both stdout and stderr to /dev/null for one compile test
The old variant of using &>/dev/null works on bash and zsh, but not on dash and tcsh. dash and tcsh interpret it as "background command and truncate /dev/null" which is not what we want. >& works on tcsh and bash, but it is not POSIX compliant. Since make uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX variant of stderr and stdout redirection. >/dev/null 2>&1 is POSIX compliant. This is specified in SuSv3, Shell Command Language, sections 2.7.2 and 2.7.6. Corresponding to flashrom svn r443 and coreboot v2 svn r4211. Signed-off-by: Stephan Guilloux <stephan.guilloux@free.fr> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Ward Vandewege <ward@gnu.org>
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index cf9570a..4699784 100644
--- a/Makefile
+++ b/Makefile
@@ -65,7 +65,7 @@ pciutils:
echo "struct pci_access *pacc;"; \
echo "int main(int argc, char **argv)"; \
echo "{ pacc = pci_alloc(); return 0; }"; ) > .test.c )
- @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) &>/dev/null && \
+ @$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >/dev/null 2>&1 && \
echo "found." || ( echo "not found."; echo; \
echo "Please install pciutils-devel and zlib-devel."; \
echo "See README for more information."; echo; \
OpenPOWER on IntegriCloud