summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2014-10-19 07:54:27 +0000
committerStefan Tauner <stefan.tauner@alumni.tuwien.ac.at>2014-10-19 07:54:27 +0000
commitff9e6c32c37e685f25e5ba09611e6e7d1a556bd8 (patch)
tree166d12b4f4831f114d046692dd712f7e96e40882
parent73f5bda01dbb1f6726593ab7a6139a1a8a1afb5a (diff)
downloadast2050-flashrom-ff9e6c32c37e685f25e5ba09611e6e7d1a556bd8.zip
ast2050-flashrom-ff9e6c32c37e685f25e5ba09611e6e7d1a556bd8.tar.gz
dmi.c: make sure we call isprint() correctly
ISO C and POSIX require to call ctype functions with values representable by unsigned char. We have used a char as input so far which might be negative and hence get sign-extended. Corresponding to flashrom svn r1852. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
-rw-r--r--dmi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/dmi.c b/dmi.c
index a7a9a61..832d7ab 100644
--- a/dmi.c
+++ b/dmi.c
@@ -142,7 +142,7 @@ static char *dmi_string(const char *buf, uint8_t string_id, const char *limit)
/* fix junk bytes in the string */
for (i = 0; i < len && buf[i] != '\0'; i++) {
- if (isprint(buf[i]))
+ if (isprint((unsigned char)buf[i]))
newbuf[i] = buf[i];
else
newbuf[i] = ' ';
OpenPOWER on IntegriCloud