1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
|
/*
* Release: "cancel" a checkout in the history log.
*
* - Enter a line in the history log indicating the "release". - If asked to,
* delete the local working directory.
*/
#include "cvs.h"
#include "savecwd.h"
#include "getline.h"
static const char *const release_usage[] =
{
"Usage: %s %s [-d] directories...\n",
"\t-d\tDelete the given directory.\n",
"(Specify the --help global option for a list of other help options)\n",
NULL
};
#ifdef SERVER_SUPPORT
static int release_server PROTO ((int argc, char **argv));
/* This is the server side of cvs release. */
static int
release_server (argc, argv)
int argc;
char **argv;
{
int i;
/* Note that we skip argv[0]. */
for (i = 1; i < argc; ++i)
history_write ('F', argv[i], "", argv[i], "");
return 0;
}
#endif /* SERVER_SUPPORT */
/* There are various things to improve about this implementation:
1. Using run_popen to run "cvs update" could be replaced by a
fairly simple start_recursion/classify_file loop--a win for
portability, performance, and cleanliness. In particular, there is
no particularly good way to find the right "cvs".
2. The fact that "cvs update" contacts the server slows things down;
it undermines the case for using "cvs release" rather than "rm -rf".
However, for correctly printing "? foo" and correctly handling
CVSROOTADM_IGNORE, we currently need to contact the server. (One
idea for how to fix this is to stash a copy of CVSROOTADM_IGNORE in
the working directories; see comment at base_* in entries.c for a
few thoughts on that).
3. Would be nice to take processing things on the client side one step
further, and making it like edit/unedit in terms of working well if
disconnected from the network, and then sending a delayed
notification.
4. Having separate network turnarounds for the "Notify" request
which we do as part of unedit, and for the "release" itself, is slow
and unnecessary. */
int
release (argc, argv)
int argc;
char **argv;
{
FILE *fp;
int i, c;
char *repository;
char *line = NULL;
size_t line_allocated = 0;
char *update_cmd;
char *thisarg;
int arg_start_idx;
int err = 0;
short delete_flag = 0;
struct saved_cwd cwd;
#ifdef SERVER_SUPPORT
if (server_active)
return release_server (argc, argv);
#endif
/* Everything from here on is client or local. */
if (argc == -1)
usage (release_usage);
optind = 0;
while ((c = getopt (argc, argv, "+Qdq")) != -1)
{
switch (c)
{
case 'Q':
case 'q':
error (1, 0,
"-q or -Q must be specified before \"%s\"",
command_name);
break;
case 'd':
delete_flag++;
break;
case '?':
default:
usage (release_usage);
break;
}
}
argc -= optind;
argv += optind;
/* We're going to run "cvs -n -q update" and check its output; if
* the output is sufficiently unalarming, then we release with no
* questions asked. Else we prompt, then maybe release.
* (Well, actually we ask no matter what. Our notion of "sufficiently
* unalarming" doesn't take into account "? foo.c" files, so it is
* up to the user to take note of them, at least currently
* (ignore-193 in testsuite)).
*/
/* Construct the update command. */
update_cmd = xmalloc (strlen (program_path)
+ strlen (CVSroot_original)
+ 20);
sprintf (update_cmd, "%s -n -q -d %s update",
program_path, CVSroot_original);
#ifdef CLIENT_SUPPORT
/* Start the server; we'll close it after looping. */
if (client_active)
{
start_server ();
ign_setup ();
}
#endif /* CLIENT_SUPPORT */
/* Remember the directory where "cvs release" was invoked because
all args are relative to this directory and we chdir around.
*/
if (save_cwd (&cwd))
error_exit ();
arg_start_idx = 0;
for (i = arg_start_idx; i < argc; i++)
{
thisarg = argv[i];
if (isdir (thisarg))
{
if (CVS_CHDIR (thisarg) < 0)
{
if (!really_quiet)
error (0, errno, "can't chdir to: %s", thisarg);
continue;
}
if (!isdir (CVSADM))
{
if (!really_quiet)
error (0, 0, "no repository directory: %s", thisarg);
if (restore_cwd (&cwd, NULL))
error_exit ();
continue;
}
}
else
{
if (!really_quiet)
error (0, 0, "no such directory: %s", thisarg);
continue;
}
repository = Name_Repository ((char *) NULL, (char *) NULL);
if (!really_quiet)
{
int line_length;
/* The "release" command piggybacks on "update", which
does the real work of finding out if anything is not
up-to-date with the repository. Then "release" prompts
the user, telling her how many files have been
modified, and asking if she still wants to do the
release. */
fp = run_popen (update_cmd, "r");
if (fp == NULL)
error (1, 0, "cannot run command %s", update_cmd);
c = 0;
while ((line_length = getline (&line, &line_allocated, fp)) >= 0)
{
if (strchr ("MARCZ", *line))
c++;
(void) printf (line);
}
if (line_length < 0 && !feof (fp))
error (0, errno, "cannot read from subprocess");
/* If the update exited with an error, then we just want to
complain and go on to the next arg. Especially, we do
not want to delete the local copy, since it's obviously
not what the user thinks it is. */
if ((pclose (fp)) != 0)
{
error (0, 0, "unable to release `%s'", thisarg);
free (repository);
if (restore_cwd (&cwd, NULL))
error_exit ();
continue;
}
printf ("You have [%d] altered files in this repository.\n",
c);
printf ("Are you sure you want to release %sdirectory `%s': ",
delete_flag ? "(and delete) " : "", thisarg);
c = !yesno ();
if (c) /* "No" */
{
(void) fprintf (stderr, "** `%s' aborted by user choice.\n",
command_name);
free (repository);
if (restore_cwd (&cwd, NULL))
error_exit ();
continue;
}
}
if (1
#ifdef CLIENT_SUPPORT
&& !(client_active
&& (!supported_request ("noop")
|| !supported_request ("Notify")))
#endif
)
{
/* We are chdir'ed into the directory in question.
So don't pass args to unedit. */
int argc = 1;
char *argv[3];
argv[0] = "dummy";
argv[1] = NULL;
err += unedit (argc, argv);
}
#ifdef CLIENT_SUPPORT
if (client_active)
{
send_to_server ("Argument ", 0);
send_to_server (thisarg, 0);
send_to_server ("\012", 1);
send_to_server ("release\012", 0);
}
else
#endif /* CLIENT_SUPPORT */
{
history_write ('F', thisarg, "", thisarg, ""); /* F == Free */
}
free (repository);
if (restore_cwd (&cwd, NULL))
error_exit ();
if (delete_flag)
{
/* FIXME? Shouldn't this just delete the CVS-controlled
files and, perhaps, the files that would normally be
ignored and leave everything else? */
if (unlink_file_dir (thisarg) < 0)
error (0, errno, "deletion of directory %s failed", thisarg);
}
#ifdef CLIENT_SUPPORT
if (client_active)
err += get_server_responses ();
#endif /* CLIENT_SUPPORT */
}
if (restore_cwd (&cwd, NULL))
error_exit ();
free_cwd (&cwd);
#ifdef CLIENT_SUPPORT
if (client_active)
{
/* Unfortunately, client.c doesn't offer a way to close
the connection without waiting for responses. The extra
network turnaround here is quite unnecessary other than
that.... */
send_to_server ("noop\012", 0);
err += get_responses_and_close ();
}
#endif /* CLIENT_SUPPORT */
free (update_cmd);
if (line != NULL)
free (line);
return err;
}
|