From 1386f27d09e8874ee89caae2f62a4906bace7be5 Mon Sep 17 00:00:00 2001 From: pst Date: Mon, 5 Aug 1996 00:31:27 +0000 Subject: Fix up some more buffer overflow problems. --- usr.sbin/cron/cron/cron.h | 4 +++- usr.sbin/cron/crontab/crontab.c | 10 ++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) (limited to 'usr.sbin') diff --git a/usr.sbin/cron/cron/cron.h b/usr.sbin/cron/cron/cron.h index 66de64b..457392f 100644 --- a/usr.sbin/cron/cron/cron.h +++ b/usr.sbin/cron/cron/cron.h @@ -17,7 +17,7 @@ /* cron.h - header for vixie's cron * - * $Id: cron.h,v 1.1.1.1 1994/08/27 13:43:04 jkh Exp $ + * $Id: cron.h,v 1.2 1995/05/30 03:46:59 rgrimes Exp $ * * vix 14nov88 [rest of log is in RCS] * vix 14jan87 [0 or 7 can be sunday; thanks, mwm@berkeley] @@ -35,6 +35,8 @@ #include #include #include +#include +#include #include "pathnames.h" #include "config.h" diff --git a/usr.sbin/cron/crontab/crontab.c b/usr.sbin/cron/crontab/crontab.c index 676c903..fbf6048 100644 --- a/usr.sbin/cron/crontab/crontab.c +++ b/usr.sbin/cron/crontab/crontab.c @@ -17,7 +17,7 @@ */ #if !defined(lint) && !defined(LINT) -static char rcsid[] = "$Id: crontab.c,v 1.3 1995/05/30 03:47:04 rgrimes Exp $"; +static char rcsid[] = "$Id: crontab.c,v 1.4 1996/04/09 20:28:16 scrappy Exp $"; #endif /* crontab - install and manage per-user crontab files @@ -167,7 +167,7 @@ parse_args(argc, argv) ProgramName, optarg); exit(ERROR_EXIT); } - (void) strcpy(User, optarg); + (void) snprintf(User, sizeof(user), "%s", optarg); break; case 'l': if (Option != opt_unknown) @@ -198,7 +198,8 @@ parse_args(argc, argv) } else { if (argv[optind] != NULL) { Option = opt_replace; - (void) strcpy (Filename, argv[optind]); + (void) snprintf(Filename, sizeof(Filename), "%s", + argv[optind]); } else { usage("file name must be specified for replace"); } @@ -480,7 +481,8 @@ edit_cmd() { ProgramName, Filename); goto done; default: - fprintf(stderr, "%s: panic: bad switch() in replace_cmd()\n"); + fprintf(stderr, "%s: panic: bad switch() in replace_cmd()\n", + ProgramName); goto fatal; } remove: -- cgit v1.1