From bf83493bdc4599da7c7f60af23bd74c0e657a98f Mon Sep 17 00:00:00 2001 From: imp Date: Fri, 10 Jan 1997 07:53:28 +0000 Subject: Fix many buffer overruns in the code. Specifically, disallow ExpandString to be used to expand things beyond the size of the buffer passed in. Also do a general cleanup of sprintf -> snprintf as well as strcpy and strncat safety. Also expand some buffers to allow for the largest possible data that might be used. This is a 2.2 candidate. However, it needs to be vetted on -current since little testing has been done on this due to my lack of PPP on this machine. Reviewed by: Jordan Hubbard, Peter Wemm, Guido van Rooij --- usr.sbin/ppp/chat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'usr.sbin/ppp/chat.h') diff --git a/usr.sbin/ppp/chat.h b/usr.sbin/ppp/chat.h index bdb6dd0..5976129 100644 --- a/usr.sbin/ppp/chat.h +++ b/usr.sbin/ppp/chat.h @@ -18,12 +18,12 @@ * Columbus, OH 43221 * (614)451-1883 * - * $Id: chat.c,v 1.5 1995/09/02 17:20:50 amurai Exp $ + * $Id: chat.h,v 1.1 1996/01/11 17:48:39 phk Exp $ * */ #ifndef _CHAT_H_ #define _CHAT_H_ #include "cdefs.h" -extern char * ExpandString __P((char *, char *, int)); +extern char * ExpandString __P((char *, char *, int, int)); extern int MakeArgs __P((char *, char **)); #endif -- cgit v1.1