From 9a63cf3a862cafec1824a6d8ccd4eb07747d71ab Mon Sep 17 00:00:00 2001 From: jkoshy Date: Wed, 19 Nov 2008 02:22:34 +0000 Subject: As a matter of good programming style, stop PMCs before releasing them. --- usr.sbin/pmcstat/pmcstat.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'usr.sbin/pmcstat') diff --git a/usr.sbin/pmcstat/pmcstat.c b/usr.sbin/pmcstat/pmcstat.c index 8cbe55b..228c78d 100644 --- a/usr.sbin/pmcstat/pmcstat.c +++ b/usr.sbin/pmcstat/pmcstat.c @@ -145,6 +145,9 @@ pmcstat_cleanup(struct pmcstat_args *a) /* release allocated PMCs. */ STAILQ_FOREACH_SAFE(ev, &a->pa_events, ev_next, tmp) if (ev->ev_pmcid != PMC_ID_INVALID) { + if (pmc_stop(ev->ev_pmcid) < 0) + err(EX_OSERR, "ERROR: cannot stop pmc 0x%x " + "\"%s\"", ev->ev_pmcid, ev->ev_name); if (pmc_release(ev->ev_pmcid) < 0) err(EX_OSERR, "ERROR: cannot release pmc " "0x%x \"%s\"", ev->ev_pmcid, ev->ev_name); -- cgit v1.1