From 8c2df19687b187984be9a4b27caba6d4bcf1b96b Mon Sep 17 00:00:00 2001 From: kan Date: Fri, 11 Jul 2003 05:47:05 +0000 Subject: Do not compare unsigned int values with ULONG_MAX. The comparison is always false on 64bit platforms and GCC 3.3.1 issues warning there. --- usr.bin/chpass/field.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'usr.bin') diff --git a/usr.bin/chpass/field.c b/usr.bin/chpass/field.c index ffa79fa..fe5b30f 100644 --- a/usr.bin/chpass/field.c +++ b/usr.bin/chpass/field.c @@ -118,7 +118,7 @@ p_uid(char *p, struct passwd *pw, ENTRY *ep __unused) } errno = 0; id = strtoul(p, &np, 10); - if (*np || (id == ULONG_MAX && errno == ERANGE)) { + if (*np || (id == (uid_t)ULONG_MAX && errno == ERANGE)) { warnx("illegal uid"); return (-1); } @@ -148,7 +148,7 @@ p_gid(char *p, struct passwd *pw, ENTRY *ep __unused) } errno = 0; id = strtoul(p, &np, 10); - if (*np || (id == ULONG_MAX && errno == ERANGE)) { + if (*np || (id == (uid_t)ULONG_MAX && errno == ERANGE)) { warnx("illegal gid"); return (-1); } -- cgit v1.1