From 683cd4b31a93f19068956a9f066f7946db88dec3 Mon Sep 17 00:00:00 2001 From: gonzo Date: Thu, 13 Dec 2012 03:33:01 +0000 Subject: Disable interrupts in filter in order to avoid interrupt storm and CPU starvation --- sys/dev/smc/if_smc.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'sys') diff --git a/sys/dev/smc/if_smc.c b/sys/dev/smc/if_smc.c index 06f6ca0..f6df350 100644 --- a/sys/dev/smc/if_smc.c +++ b/sys/dev/smc/if_smc.c @@ -807,6 +807,10 @@ smc_intr(void *context) struct smc_softc *sc; sc = (struct smc_softc *)context; + /* + * Block interrupts in order to let smc_task_intr to kick in + */ + smc_write_1(sc, MSK, 0); taskqueue_enqueue_fast(sc->smc_tq, &sc->smc_intr); return (FILTER_HANDLED); } @@ -827,13 +831,6 @@ smc_task_intr(void *context, int pending) smc_select_bank(sc, 2); /* - * Get the current mask, and then block all interrupts while we're - * working. - */ - if ((ifp->if_capenable & IFCAP_POLLING) == 0) - smc_write_1(sc, MSK, 0); - - /* * Find out what interrupts are flagged. */ status = smc_read_1(sc, IST) & sc->smc_mask; -- cgit v1.1