From 73512b9268e8caa1295e184f69ba8260f8f0a97f Mon Sep 17 00:00:00 2001 From: gibbs Date: Mon, 29 Apr 2013 23:08:13 +0000 Subject: xenstore/xenstore.c: Prevent access to invalid memory region when listing an empty directory in the XenStore. Reported by: Bei Guan MFC after: 1 week --- sys/xen/xenstore/xenstore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sys/xen') diff --git a/sys/xen/xenstore/xenstore.c b/sys/xen/xenstore/xenstore.c index 15b7f9c..090de23 100644 --- a/sys/xen/xenstore/xenstore.c +++ b/sys/xen/xenstore/xenstore.c @@ -307,7 +307,8 @@ split(char *strings, u_int len, u_int *num) const char **ret; /* Protect against unterminated buffers. */ - strings[len - 1] = '\0'; + if (len > 0) + strings[len - 1] = '\0'; /* Count the strings. */ *num = extract_strings(strings, /*dest*/NULL, len); -- cgit v1.1