From 17e14c6132be998c8e8d0c2fc89ff0b66d24999c Mon Sep 17 00:00:00 2001 From: marius Date: Tue, 22 Nov 2011 21:28:20 +0000 Subject: - There's no need to overwrite the default device method with the default one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. --- sys/pci/if_rl.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'sys/pci/if_rl.c') diff --git a/sys/pci/if_rl.c b/sys/pci/if_rl.c index 19b84d2..876461b 100644 --- a/sys/pci/if_rl.c +++ b/sys/pci/if_rl.c @@ -239,16 +239,12 @@ static device_method_t rl_methods[] = { DEVMETHOD(device_resume, rl_resume), DEVMETHOD(device_shutdown, rl_shutdown), - /* bus interface */ - DEVMETHOD(bus_print_child, bus_generic_print_child), - DEVMETHOD(bus_driver_added, bus_generic_driver_added), - /* MII interface */ DEVMETHOD(miibus_readreg, rl_miibus_readreg), DEVMETHOD(miibus_writereg, rl_miibus_writereg), DEVMETHOD(miibus_statchg, rl_miibus_statchg), - { 0, 0 } + DEVMETHOD_END }; static driver_t rl_driver = { -- cgit v1.1