From 98cd0f3cc2bc0fd4a73cf579768f3e7f8eb0fc59 Mon Sep 17 00:00:00 2001 From: sam Date: Mon, 28 Mar 2005 18:51:58 +0000 Subject: avoid potential null ptr deref by free'ing excess mbufs instead of zero'ing their length (copied from m_adj where this code came from after the equivalent change there has had time to soak) Noticed by: Coverity Prevent analysis tool --- sys/nfsserver/nfs_srvsubs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'sys/nfsserver') diff --git a/sys/nfsserver/nfs_srvsubs.c b/sys/nfsserver/nfs_srvsubs.c index 7746efc..912b5a7 100644 --- a/sys/nfsserver/nfs_srvsubs.c +++ b/sys/nfsserver/nfs_srvsubs.c @@ -949,12 +949,14 @@ nfsm_adj(struct mbuf *mp, int len, int nul) for (i = 0; i < nul; i++) *cp++ = '\0'; } + if (m->m_next != NULL) { + m_freem(m->m_next); + m->m_next = NULL; + } break; } count -= m->m_len; } - for (m = m->m_next;m;m = m->m_next) - m->m_len = 0; } /* -- cgit v1.1