From 3a2d39f8a2c5a1506f00bdd70936c4bce749b9f5 Mon Sep 17 00:00:00 2001 From: bz Date: Fri, 15 Jun 2007 22:35:59 +0000 Subject: With the current code 'src' is never NULL. Nevertheless move the check for NULL before dereferencing the pointer. Found with: Coverity Prevent(tm) CID: 2528 --- sys/netipsec/key.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'sys/netipsec/key.c') diff --git a/sys/netipsec/key.c b/sys/netipsec/key.c index 0f27f87..2f0dc7e 100644 --- a/sys/netipsec/key.c +++ b/sys/netipsec/key.c @@ -7296,11 +7296,13 @@ key_setkey(struct seckey *src, u_int16_t exttype) { struct mbuf *m; struct sadb_key *p; - int len = PFKEY_ALIGN8(sizeof(struct sadb_key) + _KEYLEN(src)); + int len; if (src == NULL) return NULL; + len = PFKEY_ALIGN8(sizeof(struct sadb_key) + _KEYLEN(src)); + m = key_alloc_mbuf(len); if (m == NULL) return NULL; -- cgit v1.1