From f0509c05efb30c85fadfd8ef036298ea187cfeaf Mon Sep 17 00:00:00 2001 From: phk Date: Sun, 17 Sep 2000 11:34:33 +0000 Subject: Make sure UDP sockets are explicitly bind(2)'ed [sic] before we connect(2) them. PR: 20946 Isolated by: Aaron Gifford --- sys/netinet/udp_usrreq.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'sys/netinet') diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c index 07b1166..6a86879 100644 --- a/sys/netinet/udp_usrreq.c +++ b/sys/netinet/udp_usrreq.c @@ -827,10 +827,15 @@ udp_connect(struct socket *so, struct sockaddr *nam, struct proc *p) return EINVAL; if (inp->inp_faddr.s_addr != INADDR_ANY) return EISCONN; + error = 0; s = splnet(); - sin = (struct sockaddr_in *)nam; - prison_remote_ip(p, 0, &sin->sin_addr.s_addr); - error = in_pcbconnect(inp, nam, p); + if (inp->inp_laddr.s_addr == INADDR_ANY && p->p_prison != NULL) + error = in_pcbbind(inp, NULL, p); + if (error == 0) { + sin = (struct sockaddr_in *)nam; + prison_remote_ip(p, 0, &sin->sin_addr.s_addr); + error = in_pcbconnect(inp, nam, p); + } splx(s); if (error == 0) soisconnected(so); -- cgit v1.1